Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect PointCloudShape transparency #1330

Merged
merged 3 commits into from
May 21, 2019

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented May 21, 2019

image


Before creating a pull request

  • Document new methods and classes
  • Format new code files using clang-format

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change (N/A)

@jslee02 jslee02 added this to the DART 6.9.0 milestone May 21, 2019
@codecov
Copy link

codecov bot commented May 21, 2019

Codecov Report

Merging #1330 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #1330      +/-   ##
=========================================
+ Coverage   56.89%   56.9%   +0.01%     
=========================================
  Files         366     366              
  Lines       27167   27167              
=========================================
+ Hits        15457   15460       +3     
+ Misses      11710   11707       -3
Impacted Files Coverage Δ
dart/dynamics/Skeleton.cpp 66.12% <0%> (+0.16%) ⬆️

@jslee02 jslee02 marked this pull request as ready for review May 21, 2019 01:33
@jslee02 jslee02 merged commit d70547b into master May 21, 2019
@jslee02 jslee02 deleted the bugfix/enable_point_cloud_alpha branch May 21, 2019 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant