Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set data variance of PointCloudShapeNode to DYNAMIC #1355

Merged
merged 3 commits into from
Jun 7, 2019
Merged

Set data variance of PointCloudShapeNode to DYNAMIC #1355

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
661816a
Set data variance of PointCloudShapeNode to DYNAMIC
Jun 6, 2019
d77dea2
Merge branch 'master' into bugfix/point_cloud_data_variance
jslee02 Jun 7, 2019
c846b4b
Update CHANGELOG.md
jslee02 Jun 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* GUI

* Fixed memory leaks from dart::gui::osg::Viewer: [#1349](https://github.com/dartsim/dart/pull/1349)
* Added point rendering mode to PointCloudShape: [#1351](https://github.com/dartsim/dart/pull/1351)
* Added point rendering mode to PointCloudShape: [#1351](https://github.com/dartsim/dart/pull/1351), [#1355](https://github.com/dartsim/dart/pull/1355)

* dartpy

Expand Down
1 change: 1 addition & 0 deletions dart/gui/osg/render/PointCloudShapeNode.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -489,6 +489,7 @@ class VertexPointNodes final : public PointNodes
mGeometry->addPrimitiveSet(mPrimitiveSet);
mGeometry->getOrCreateStateSet()->setAttribute(
mPoint, ::osg::StateAttribute::ON);
mGeometry->setDataVariance(::osg::Object::DYNAMIC);

mGeode = new ::osg::Geode();
mGeode->getOrCreateStateSet()->setMode(
Expand Down