Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove specifying suffix and prefix of python module #1378

Merged
merged 1 commit into from
Jul 26, 2019

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Jul 26, 2019

They are set by pybind11_add_module().


Before creating a pull request

  • Document new methods and classes (N/A)
  • Format new code files using clang-format (N/A)

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md (N/A)
  • Add unit test(s) for this change (N/A)

@jslee02 jslee02 added this to the DART 6.10.0 milestone Jul 26, 2019
@codecov
Copy link

codecov bot commented Jul 26, 2019

Codecov Report

Merging #1378 into master will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1378      +/-   ##
==========================================
+ Coverage   56.95%   56.98%   +0.03%     
==========================================
  Files         366      366              
  Lines       27460    27460              
==========================================
+ Hits        15640    15649       +9     
+ Misses      11820    11811       -9
Impacted Files Coverage Δ
dart/dynamics/Skeleton.cpp 66.22% <0%> (+0.16%) ⬆️
dart/dynamics/EulerJoint.cpp 73% <0%> (+3.68%) ⬆️

@jslee02 jslee02 merged commit d8f2636 into master Jul 26, 2019
@jslee02 jslee02 deleted the python_module_suffix branch July 26, 2019 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant