Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Inertia python bindings #1388

Merged
merged 9 commits into from
Aug 14, 2019
Merged

Add Inertia python bindings #1388

merged 9 commits into from
Aug 14, 2019

Conversation

chhinze
Copy link
Contributor

@chhinze chhinze commented Aug 13, 2019 •
edited by jslee02
Loading

Adds the following:

  • Bindings for class dart::dynamics::Inertia
  • Access for dart::dynamics::BodyNode::getInertia
  • unittests for new bindings

Before creating a pull request

  • Document new methods and classes
  • Format new code files using clang-format

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change

@codecov
Copy link

codecov bot commented Aug 13, 2019 •
edited
Loading

Codecov Report

Merging #1388 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1388   +/-   ##
=======================================
  Coverage   57.27%   57.27%           
=======================================
  Files         366      366           
  Lines       27432    27432           
=======================================
  Hits        15711    15711           
  Misses      11721    11721

@jslee02 jslee02 added this to the DART 6.10.0 milestone Aug 14, 2019
jslee02
jslee02 requested changes Aug 14, 2019
View reviewed changes
Copy link
Member

@jslee02 jslee02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor style comments. Looks good to me other than that.

python/dartpy/dynamics/Inertia.cpp Show resolved Hide resolved
python/dartpy/dynamics/Inertia.cpp Outdated Show resolved Hide resolved
python/tests/unit/dynamics/test_body_node.py Outdated Show resolved Hide resolved
python/tests/unit/dynamics/test_body_node.py Outdated Show resolved Hide resolved
chhinze and others added 3 commits August 14, 2019 09:21
@chhinze @jslee02
Consistent naming in python/tests/unit/dynamics/test_body_node.py
37471c1 
Co-Authored-By: Jeongseok Lee <jslee02@users.noreply.github.com>
@chhinze @jslee02
Consistent naming in python/tests/unit/dynamics/test_body_node.py
b777f9b 
Co-Authored-By: Jeongseok Lee <jslee02@users.noreply.github.com>
@chhinze
Add newline to end of file dartpy/dyamics/Inertia.cpp
c661032
jslee02
jslee02 approved these changes Aug 14, 2019
View reviewed changes
Copy link
Member

@jslee02 jslee02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this once CI test pass. Thank you for the contribution!

@jslee02 jslee02 merged commit 4e8180f into dartsim:master Aug 14, 2019
@chhinze
Copy link
Contributor Author

chhinze commented Aug 15, 2019

Awesome. Thank you for the review and for merging.

@chhinze chhinze deleted the fix/pyAddInertiaAccess branch August 15, 2019 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jslee02 jslee02 jslee02 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
DART 6.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@chhinze @jslee02