Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FindBullet: separate win32 optimized and debug libraries #1395

Merged
merged 3 commits into from
Aug 16, 2019

Conversation

scpeters
Copy link
Collaborator

@scpeters scpeters commented Aug 16, 2019

I see a configuration error on windows when trying to build dart with bullet3 installed from vcpkg:

CMake Error at cmake/DARTFindBullet.cmake:16 (set_target_properties):
  Property INTERFACE_LINK_LIBRARIES may not contain link-type keyword
  "optimized".  The INTERFACE_LINK_LIBRARIES property may contain
  configuration-sensitive generator-expressions which may be used to specify
  per-configuration rules.

There are multiple optimized and debug libraries interleaved in the BULLET_LIBRARIES parameter, so we can't use the simple approach from 73ef8c2. I've used cmake_parse_arguments to separate the debug and optimized libraries, and I think I set up the generator expressions correctly, but I'm not sure. I've added bullet3 and ode to the list of vcpkg packages to install in azure-pipeline, so CI should confirm if this fix is working.


Before creating a pull request

  • Document new methods and classes
  • Format new code files using clang-format

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change

@jslee02 jslee02 added this to the DART 6.10.0 milestone Aug 16, 2019
@codecov
Copy link

codecov bot commented Aug 16, 2019

Codecov Report

Merging #1395 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1395   +/-   ##
=======================================
  Coverage   57.27%   57.27%           
=======================================
  Files         366      366           
  Lines       27432    27432           
=======================================
  Hits        15711    15711           
  Misses      11721    11721

.azure-pipelines.yml Outdated Show resolved Hide resolved
@jslee02 jslee02 merged commit 6b023c2 into dartsim:master Aug 16, 2019
@scpeters scpeters deleted the find_bullet_win32 branch August 16, 2019 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants