-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use cmake message WARNING and SEND_ERROR when appropriate #1401
Conversation
I think |
Yeah, I guess it's only detecting the version with pkg-config, which isn't available on windows. I can revert that change or add an |
It seems assimp 4.1 installs if(WIN32)
find_package(assimp REQUIRED CONFIG)
else()
find_package(assimp REQUIRED MODULE)
endif() I'm not sure if using the version config file would change the version variable name to |
It looks like xenial has assimp 3.2, which has the cmake config files: |
I'll split the assimp change to a separate pull request |
Codecov Report
@@ Coverage Diff @@
## master #1401 +/- ##
==========================================
+ Coverage 57.27% 57.28% +0.01%
==========================================
Files 366 366
Lines 27432 27483 +51
==========================================
+ Hits 15711 15743 +32
- Misses 11721 11740 +19
|
Sorry I saw an inconsistent warning message, so I updated it in 22a2fc7 |
When compiling with colcon, messages to stdout (such as
message(STATUS)
calls from cmake) are not displayed on the console, while messages to stderr (such asmessage(WARNING)
andmessage(SEND_ERROR)
) are displayed, which makes it much easier to spot configuration issues. I noticed that many places there aremessage(STATUS)
calls notifying when optional dependencies could not be found, so I changed those tomessage(WARNING)
. I also noticed one place in DARTFindassimp.cmake (e4ca1a8) that seemed like it should cause the build to fail, so I changed that frommessage(STATUS)
tomessage(SEND_ERROR)
.Before creating a pull request
clang-format
Before merging a pull request
CHANGELOG.md