Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation warnings from VS2019 #1402

Merged
merged 3 commits into from
Aug 17, 2019
Merged

Fix compilation warnings from VS2019 #1402

merged 3 commits into from
Aug 17, 2019

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Aug 17, 2019

Build log of the warnings


Before creating a pull request

  • Document new methods and classes
  • Format new code files using clang-format

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change

@jslee02 jslee02 added this to the DART 6.10.0 milestone Aug 17, 2019
@codecov
Copy link

codecov bot commented Aug 17, 2019

Codecov Report

Merging #1402 into master will increase coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #1402      +/-   ##
==========================================
+ Coverage   57.27%   57.28%   +0.01%     
==========================================
  Files         366      366              
  Lines       27432    27432              
==========================================
+ Hits        15711    15714       +3     
+ Misses      11721    11718       -3
Impacted Files Coverage Δ
dart/utils/XmlHelpers.cpp 60.84% <0%> (ø) ⬆️
dart/dynamics/SharedLibraryIkFast.cpp 49.41% <0%> (ø) ⬆️
dart/dynamics/Skeleton.cpp 66.22% <0%> (+0.16%) ⬆️

@jslee02 jslee02 changed the title Fix warnings from vs2019 Fix compilation warnings from VS2019 Aug 17, 2019
@jslee02 jslee02 merged commit 7ed5bc3 into master Aug 17, 2019
@jslee02 jslee02 deleted the fix_warnings_vs2019 branch August 17, 2019 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant