Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on Boost::regex #1412

Merged
merged 3 commits into from
Sep 8, 2019
Merged

Remove dependency on Boost::regex #1412

merged 3 commits into from
Sep 8, 2019

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Sep 7, 2019

The implementation bug of GCC is no longer issue since DART requires GCC >= 5.3.1.


Before creating a pull request

  • Document new methods and classes
  • Format new code files using clang-format

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change

@jslee02 jslee02 added this to the DART 6.10.0 milestone Sep 7, 2019
@codecov
Copy link

codecov bot commented Sep 7, 2019

Codecov Report

Merging #1412 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1412      +/-   ##
==========================================
+ Coverage   57.31%   57.32%   +0.01%     
==========================================
  Files         367      367              
  Lines       27521    27521              
==========================================
+ Hits        15774    15777       +3     
+ Misses      11747    11744       -3
Impacted Files Coverage Δ
dart/common/Uri.cpp 68.82% <ø> (ø) ⬆️
dart/utils/XmlHelpers.cpp 60.84% <ø> (ø) ⬆️
dart/dynamics/Skeleton.cpp 66.22% <0%> (+0.16%) ⬆️

@jslee02 jslee02 changed the title Remove dependency of Boost::regex Remove dependency on Boost::regex Sep 7, 2019
@jslee02 jslee02 merged commit 110269c into master Sep 8, 2019
@jslee02 jslee02 deleted the boost_regex branch September 8, 2019 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant