Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OSG transparent object sorting #1414

Merged
merged 3 commits into from
Sep 16, 2019
Merged

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Sep 15, 2019

Transparent objects sometimes cannot be seen through other transparent objects. This seems to happen because the objects are not properly grouped for z-depth sorting. This PR is to fix it referencing this post.

Current behavior:
before

New behavior with this fix:
after


Before creating a pull request

  • Document new methods and classes
  • Format new code files using clang-format

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change

@jslee02 jslee02 added this to the DART 6.10.0 milestone Sep 15, 2019
@jslee02 jslee02 marked this pull request as ready for review September 15, 2019 18:19
@codecov
Copy link

codecov bot commented Sep 15, 2019

Codecov Report

Merging #1414 into master will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1414      +/-   ##
==========================================
+ Coverage   57.29%   57.31%   +0.02%     
==========================================
  Files         367      367              
  Lines       27521    27521              
==========================================
+ Hits        15768    15774       +6     
+ Misses      11753    11747       -6
Impacted Files Coverage Δ
dart/common/Uri.cpp 68.82% <ø> (ø) ⬆️
dart/dynamics/EulerJoint.cpp 73% <0%> (+3.68%) ⬆️

@jslee02 jslee02 merged commit e9c0ae6 into master Sep 16, 2019
@jslee02 jslee02 deleted the bugfix/fix_osg_transparency branch September 16, 2019 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant