Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MJCF (MuJoCo model file format) parser #1416

Merged
merged 6 commits into from
Sep 20, 2019
Merged

Add MJCF (MuJoCo model file format) parser #1416

merged 6 commits into from
Sep 20, 2019

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Sep 16, 2019

This PR adds experimental MJCF parser that implements a subset of the MJCF spec.

Some of MJCF files are copied from OpenAI Gym for testing and an example. The license file is included.

Fetch model controlling the end-effector using weld joint constraint:
fetch2


Before creating a pull request

  • Document new methods and classes
  • Format new code files using clang-format

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change

@jslee02 jslee02 added this to the DART 6.10.0 milestone Sep 16, 2019
@jslee02 jslee02 marked this pull request as ready for review September 16, 2019 03:50
# Conflicts:
#	dart/gui/osg/render/BoxShapeNode.cpp
#	dart/gui/osg/render/CapsuleShapeNode.cpp
#	dart/gui/osg/render/ConeShapeNode.cpp
#	dart/gui/osg/render/CylinderShapeNode.cpp
#	dart/gui/osg/render/EllipsoidShapeNode.cpp
#	dart/gui/osg/render/HeightmapShapeNode.hpp
#	dart/gui/osg/render/LineSegmentShapeNode.cpp
#	dart/gui/osg/render/MeshShapeNode.cpp
#	dart/gui/osg/render/MultiSphereShapeNode.cpp
#	dart/gui/osg/render/PlaneShapeNode.cpp
#	dart/gui/osg/render/PointCloudShapeNode.cpp
#	dart/gui/osg/render/SoftMeshShapeNode.cpp
#	dart/gui/osg/render/SphereShapeNode.cpp
#	dart/gui/osg/render/VoxelGridShapeNode.cpp
@codecov
Copy link

codecov bot commented Sep 16, 2019

Codecov Report

Merging #1416 into master will increase coverage by 0.8%.
The diff coverage is 64.85%.

@@            Coverage Diff            @@
##           master    #1416     +/-   ##
=========================================
+ Coverage   57.22%   58.03%   +0.8%     
=========================================
  Files         367      412     +45     
  Lines       27568    29796   +2228     
=========================================
+ Hits        15775    17291   +1516     
- Misses      11793    12505    +712
Impacted Files Coverage Δ
dart/common/ResourceRetriever.hpp 100% <ø> (ø) ⬆️
dart/dynamics/Skeleton.hpp 83.33% <ø> (ø) ⬆️
dart/utils/mjcf/detail/Error.hpp 0% <0%> (ø)
dart/utils/XmlHelpers.hpp 43.18% <0%> (-51.82%) ⬇️
dart/utils/mjcf/detail/Error.cpp 0% <0%> (ø)
dart/utils/mjcf/detail/Option.hpp 100% <100%> (ø)
dart/utils/mjcf/detail/Inertial.hpp 100% <100%> (ø)
dart/utils/mjcf/detail/Joint.hpp 100% <100%> (ø)
dart/utils/mjcf/detail/Body.hpp 100% <100%> (ø)
dart/utils/mjcf/detail/BodyAttributes.hpp 100% <100%> (ø)
... and 96 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant