Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: update tutorial doc to reflect new APIs #1481

Merged
merged 7 commits into from
Aug 16, 2020

Conversation

alinen
Copy link
Contributor

@alinen alinen commented Aug 6, 2020

Update tutorial text to use current API for visualization aspects on shape nodes


Before creating a pull request

  • Document new methods and classes
  • Format new code files using clang-format

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change

@codecov
Copy link

codecov bot commented Aug 6, 2020

Codecov Report

Merging #1481 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1481   +/-   ##
=======================================
  Coverage   58.05%   58.05%           
=======================================
  Files         414      414           
  Lines       30004    30004           
=======================================
  Hits        17419    17419           
  Misses      12585    12585           

Copy link
Member

@jslee02 jslee02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! I left a few style suggestions that are to be consistent with the code style in each tutorial.

By the way, the tutorials in this repo are not synced with the ones on the website. I'll update the website based on this PR.

docs/readthedocs/tutorials/biped.md Outdated Show resolved Hide resolved
docs/readthedocs/tutorials/multi-pendulum.md Outdated Show resolved Hide resolved
docs/readthedocs/tutorials/collisions.md Outdated Show resolved Hide resolved
alinen and others added 4 commits August 13, 2020 12:59
Co-authored-by: Jeongseok Lee <jslee02@users.noreply.github.com>
Co-authored-by: Jeongseok Lee <jslee02@users.noreply.github.com>
Co-authored-by: Jeongseok Lee <jslee02@users.noreply.github.com>
@jslee02 jslee02 merged commit a0a11f9 into dartsim:master Aug 16, 2020
jslee02 added a commit that referenced this pull request Aug 16, 2020
Co-authored-by: Jeongseok Lee <jslee02@users.noreply.github.com>
Co-authored-by: alinen <anormy1@swarthmore.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants