Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix installing dependencies on macOS image #1530

Merged
merged 1 commit into from
Dec 29, 2020
Merged

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Dec 28, 2020

No description provided.

@jslee02 jslee02 added this to the DART 6.10.0 milestone Dec 28, 2020
@jslee02 jslee02 marked this pull request as draft December 29, 2020 00:37
@codecov
Copy link

codecov bot commented Dec 29, 2020

Codecov Report

Merging #1530 (46dfb0f) into master (41dac54) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1530      +/-   ##
==========================================
+ Coverage   58.17%   58.18%   +0.01%     
==========================================
  Files         414      414              
  Lines       30008    30008              
==========================================
+ Hits        17456    17459       +3     
+ Misses      12552    12549       -3     
Impacted Files Coverage Δ
dart/dynamics/Skeleton.cpp 66.39% <0.00%> (+0.16%) ⬆️

@jslee02 jslee02 marked this pull request as ready for review December 29, 2020 03:56
@jslee02 jslee02 changed the title Remove workaround for Homebrew update failure Fix installing dependencies on macOS image Dec 29, 2020
@jslee02 jslee02 merged commit 0ef6753 into master Dec 29, 2020
@jslee02 jslee02 deleted the install_osx_deps branch December 29, 2020 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant