Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix windows near far #1675

Merged
merged 2 commits into from
Jul 31, 2022
Merged

Fix windows near far #1675

merged 2 commits into from
Jul 31, 2022

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Jul 31, 2022

Fixes #1671


Before creating a pull request

  • Document new methods and classes
  • Format new code files using ClangFormat by running make format
  • Build with -DDART_TREAT_WARNINGS_AS_ERRORS=ON and resolve all the compile warnings

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change
  • Add Python bindings for new methods and classes

@jslee02 jslee02 added this to the DART 6.12.2 milestone Jul 31, 2022
@jslee02 jslee02 linked an issue Jul 31, 2022 that may be closed by this pull request
2 tasks
@codecov
Copy link

codecov bot commented Jul 31, 2022

Codecov Report

Merging #1675 (fdec549) into release-6.12 (86249fd) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           release-6.12    #1675      +/-   ##
================================================
- Coverage         59.13%   59.11%   -0.02%     
================================================
  Files               477      477              
  Lines             39945    39945              
================================================
- Hits              23620    23615       -5     
- Misses            16325    16330       +5     
Impacted Files Coverage Δ
dart/dynamics/EulerJoint.cpp 70.17% <0.00%> (-2.93%) ⬇️

@jslee02 jslee02 marked this pull request as ready for review July 31, 2022 16:31
@jslee02 jslee02 merged commit 1555320 into release-6.12 Jul 31, 2022
@jslee02 jslee02 deleted the fix_windows_near_far branch January 10, 2023 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[urdfdom] Build failure on Windows with urdfdom version 3.1.0
1 participant