Fix API compatibility of dart 4.3 #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…x_api_compatibility Conflicts: cmake/DARTMacros.cmake dart/constraint/CMakeLists.txt tools/issue_303_generator.bash
| @@ -70,14 +70,14 @@ endmacro() | |||
| # Copied from https://bitbucket.org/osrf/gazebo/pull-request/638 and will be | |||
| # removed by DART 5.0 | |||
| #=============================================================================== | |||
| macro(dt_issue_303 _name) | |||
| macro(dt_issue_303 _name _output_name) | |||
| if (FILESYSTEM_CASE_SENSITIVE) | |||
| if (${DART_VERSION} VERSION_GREATER 4.3) | |||
| message(WARNING "Installing deprecated ${_name}.hh. This should be removed after Gazebo 4.3") | |||
jslee02
added
Comp: API
priority: high
| @@ -81,7 +82,10 @@ class LCPSolver { | |||
| const Eigen::VectorXd& _x); | |||
| }; | |||
|
|
|||
| DEPRECATED(4.3) | |||
| typedef ODELCPSolver ODELCPSolver; | |||
|
|
gazebo is building successfully now with the deprecation warnings |
|
Cool. +1 |
jslee02
added a commit
that referenced
this pull request
Jan 22, 2015
Fix API compatibility of dart 4.3
| macro(dt_issue_303 _name _output_name) | ||
| if (FILESYSTEM_CASE_SENSITIVE) | ||
| if (${DART_VERSION} VERSION_GREATER 4.3) | ||
| message(WARNING "Installing deprecated ${_name}.hh. This should be removed after DART 4.3") |
There was a problem hiding this comment.
Should be removed after DART 5.0?
There was a problem hiding this comment.
If it means "removed by DART 5.0", yes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the API incompatibility introduced by dart 4.3.
Fix #303