Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed a small bug in loading WorldFile #325

Merged
merged 3 commits into from
Feb 1, 2015
Merged

Fixed a small bug in loading WorldFile #325

merged 3 commits into from
Feb 1, 2015

Conversation

karenliu
Copy link
Member

No description provided.

@jslee02
Copy link
Member

jslee02 commented Jan 29, 2015

I added an unit test for FileInfoWorld. It checks whether the world's recording and the saved recording are identical. fullbody1 is used for the test.

Also, FileInfoWorld deletes Recording before creates a new one to prevent memory leak. If FileInfoWorld create the first Recording then it will try to delete null pointer, but it's fine because delete doesn't do anything for null pointer.

If all the build tests are happy then +1.

@jslee02 jslee02 added this to the Release DART 5.0 milestone Jan 29, 2015
karenliu added a commit that referenced this pull request Feb 1, 2015
@karenliu
Merge pull request #325 from dartsim/worldFileLoadFix
b2cca27 
Fixed a small bug in loading WorldFile
@karenliu karenliu merged commit b2cca27 into master Feb 1, 2015
@karenliu karenliu deleted the worldFileLoadFix branch February 17, 2015 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
DART 5.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@karenliu @jslee02 @ckarenliu