Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing bullet includes #352

Merged
merged 1 commit into from
Mar 19, 2015
Merged

Add missing bullet includes #352

merged 1 commit into from
Mar 19, 2015

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Mar 16, 2015

Fixes #351

@jslee02 jslee02 added this to the Release DART 4.3 milestone Mar 16, 2015
jslee02 added a commit that referenced this pull request Mar 19, 2015
@jslee02
Merge pull request #352 from dartsim/bullet_includes
b988923 
Add missing bullet includes
@jslee02 jslee02 merged commit b988923 into release-4.3 Mar 19, 2015
@jslee02 jslee02 mentioned this pull request Mar 19, 2015
Closed
scpeters added a commit that referenced this pull request Mar 21, 2015
@scpeters
Fix BULLET_INCLUDE_DIRS in DARTCoreConfig.cmake
dbc3df4 
The fix from #352 doesn't work if the downstream code
doesn't have the HAVE_BULLET_COLLISION variable defined.
This change just inserts the BULLET_INCLUDE_DIRS
variable into DARTCore_INCLUDE_DIRS
and trusts that it will be blank and not affect
anything if it is unset.

Closes #351.
@scpeters scpeters mentioned this pull request Mar 21, 2015
Merged
@jslee02 jslee02 deleted the bullet_includes branch March 24, 2015 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
DART 4.3.0
Development

Successfully merging this pull request may close these issues.
1 participant
@jslee02