-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store path to mesh in MeshShape #397
Store path to mesh in MeshShape #397
Conversation
I noticed that "testDynamics" is failing on Travis. I didn't make any changes to the dynamics code, so I suspect that this is caused by previous changes in the @mxgrey Is that possible? |
testDynamics was failing temporarily while I was merging the master branch (with the new finite differencing feature) into memory_management. But I believe I fixed the cause the of the failure before I even finalized the commit for the merge. Strangely, the test only failed in one configuration (Mac / clang / release) and passed in all the others. Unfortunately, there's no way (that I know of) to obtain more detailed information about what failed. Considering how finicky clang has been on Travis lately, all I can think of doing is telling Travis to rerun it. If it fails again, then we'll need to find someone who can test that configuration on their own machine to get us more details about what's failing. |
I've now rerun it, and the same failure pops up. It's definitely a problem that originated in memory_management. It only fails on Mac / Clang / release, so if anyone has a Mac that they can test it on, that would be very helpful. My best guess is that there are some differences in the implementation of |
|
Also, use |
Thanks, @scpeters ! Did it also print out the values of detlaVel1 and deltaVel2? Are they far off, or just barely shy of a tolerance of 1e-5? Next time this happens, I'll push a commit with |
@mxgrey Besides the |
Looks good. Does the path name only matter for URDF? I could add it to the Skel and SDF parsers as well. |
We should add it anywhere that we load meshes from disk (which includes the |
Store path to mesh in MeshShape
I can merge it in and add it to the other parsers. |
@mxgrey sorry I didn't paste the whole output. I just looked for the failure and pasted that. I also deleted the build already. IMO, the |
This pull request adds a
getMeshPath
method toMeshShape
. This returns the path to mesh on disk if it is available. If not, it returns an empty string (the default behavior).This information is necessary to render meshes with non-embedded textures. Assimp references external textures with a path relative to the directory containing the mesh.