Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows build issues: NOMINMAX and "small" variable name #482

Merged
merged 3 commits into from
Aug 2, 2015

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Aug 1, 2015

This pull request partially resolves Windows build issues reported in #411: NOMINMAX and "small" variable name.

@jslee02 jslee02 added this to the DART 5.1.0 milestone Aug 1, 2015
@mxgrey
Copy link
Member

mxgrey commented Aug 2, 2015

👍

I ran into a similar issue with the min macro on Windows in pull request #461. My lazy solution was to simply #define NOMINMAX all over the place, but I should probably do something closer to this if possible.

@jslee02
Copy link
Member Author

jslee02 commented Aug 2, 2015

I got the solution from #411 thanks to @jturner65. I just wish Windows is compatible with standard C++. :)

jslee02 added a commit that referenced this pull request Aug 2, 2015
Fix Windows build issues: NOMINMAX and "small" variable name
@jslee02 jslee02 merged commit 99ed8a6 into master Aug 2, 2015
@jslee02 jslee02 deleted the windows_build_issues branch August 2, 2015 11:05
@jturner65
Copy link

yeah, me too @jslee02 .I hope it doesn't take M$ so long in the future to adopt subsequent standards upgrades. I am glad I could help you guys a bit. I will be glad to check on any windows-specific issues in the future, if you guys need any assistance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants