Fix build issues on Windows #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jslee02
changed the title
... until x64 version of dart-prerequisites is ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes fixes on multiple build issues on Windows:
OS identification macro is dependent on compilers. DART used to use
WIN32for Windows but_WIN32is the portable macro. Here are another references I found: [1], [2].The use of
GL_MULTISAMPLEon Windows is disabled until we find portable way for anti-aliasing. See Windows Issues with current Master build #411.Change default run-time library option from /MT to /MD for Visual Studio
libccdis a explicit dependency of DART but the libraries and include directories were not added to CMakeLists.txtSet cmake policy
CMP0053to new.See MSVC bug on template function specialization with default argument #487.
Updating appveyor script and dart-prerequisites-msvc12-md-x86.msi