API for utilizing Analytical IK #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am in the process of integrating HERB's |
|
Looks like AppVeyor had a server issue. |
| mHubo->getJoint(0)->setPositions(FreeJoint::convertToPositions(new_tf)); | ||
| } | ||
|
|
||
| bool solved = mHubo->getIK(true)->solve(); |
There was a problem hiding this comment.
Unused variable warning here. I guess you used this variable for debugging.
| @@ -428,6 +428,22 @@ bool verifyRotation(const Eigen::Matrix3d& _R); | |||
| /// all the elements are not NaN values. | |||
| bool verifyTransform(const Eigen::Isometry3d& _T); | |||
|
|
|||
| /// Get the remainder of dividing x by y | |||
| inline double mod(double x, double y) | |||
| { | |||
There was a problem hiding this comment.
Any reason we don't use std::fmod(double, double)?
There was a problem hiding this comment.
Mostly because I did not know that function existed. Good catch!
|
👍 Looks good to me. |
jslee02
added a commit
that referenced
this pull request
Nov 11, 2015
API for utilizing Analytical IK
jslee02
added a commit
that referenced
this pull request
Nov 14, 2015
API for utilizing Analytical IK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces an API for creating and utilizing analytical inverse kinematics modules into the IK framework that was created in #461 .
It should be noted that implementing an analytical IK solver for a particular robot is up to the user; the role of this API is to allow user-created analytical solvers to be plugged into the framework in an efficient and semantically meaningful way.