Workaround for ftell bug in Linux #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ftell returns LONG_MAX as an error code, instead of -1L as specified in the documentation, when invoked on a directory. This behavior occurs on EXT4 filesystems, not but NFSv4 file systems, in kernel version 3.16.0 possibly with Ubuntu-specific patches applied (tested in Ubuntu 14.04).
|
Looks good to me 👍 System or compiler dependent behavior is mostly troublesome.. |
|
Looks good. 👍 AppVeyor might need a restart, though. |
|
AppVeyor keeps failing for release mode tests because they exceeds the limited time, 60 min. But it should have nothing to do with this PR. Merging.. If anyone have an idea to boost AppVeyor buildings, I would like to share. 😓 |
jslee02
added a commit
that referenced
this pull request
Oct 21, 2015
Workaround for ftell bug in Linux
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ftellreturnsLONG_MAXas an error code, instead of-1Las specified in the documentation, when invoked on a directory. This behavior occurs on EXT4 filesystems, not but NFSv4 file systems, in kernel version 3.16.0 possibly with Ubuntu-specific patches applied (tested in Ubuntu 14.04).This was not a fun one to debug. 😓