Improved wording of the cmake warning messages for ASSIMP

[mxgrey]

I felt that the wording of the cmake warning messages for ASSIMP might be difficult to understand, so I attempted to improve their clarity a bit.

[psigen]

👍 These are a lot clearer.

Do we know which version of Assimp this issue was fixed in? It may be helpful to specify "Assimp 3.0.0+" or something, since I wouldn't know what version of Assimp to try if this issue came up.

[jslee02]

Looks better now 👍

There are two classes that Assimp 3.0~dfsg-3 (package in vivid) is missing: aiMaterial and aiScene. The symbols of aiMaterial were included in Assimp 3.0~dfsg-4 (package in wily) but not of aiScene. So any released package of Assimp has not completely fixed the issue yet.

[mxgrey]

Then maybe we should add "once one becomes available" to the warning message.

We wouldn't want to send users on a futile search for a library version that doesn't exist.

[jslee02]

Good idea.

I haven't tested yet for all the platforms again, but it seems only the versions of Assimp in the ubuntu package system have this issue. So I would like to update the recommendation sentence to "using a version of ASSIMP package that does not have this issue once one becomes available". Also, we could encourage people to build and install ASSIMP from the source.

[jslee02]

This branch needs to merge master into this branch in order to be merged into master back. No conflicts were sufficient condition to be merged into master when master was not a protected branch. However, now it seems to require to check if the changes of master, that was made after this branch was branched out, pass the status checks with this branch.

Regarding the warning message, just adding "once one becomes available" is also fine to me.

Edit: The requirement seems to be too restrictive so it's disabled. Now protected branches are just prevented from being deleted and force pushed.

[jslee02]

Either of @mxgrey 's suggestion and just current message looks good to me. I think we could merge this pull unless there is more idea.

[mxgrey]

I'll tweak the message tonight, and then I think it'll be ready to merge.

[jslee02]

Thanks, @mxgrey. Don't need to rush. Just wondered your think on this. Please tweak the message when you have a chance.

[mxgrey]

The comment has been updated. I believe this is ready to merge.

[jslee02]

👍