Fix control file for missing urdfdom-dev dep #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We've updated the changelog in a separate pull request before the release, but adding items per pull request would be a preferable way of managing changelog. Indeed, you can add an item to the changelog, but it's not mandatory. |
|
Should I added it in |
|
Since 5.1.1 is already released, it would be good to add it in 6.0.0. |
|
Is the changelog good? |
|
It looks good. Could you add it to Changelog.md too? Thanks! |
|
It should be okay now! |
|
Everything looks good. Will merge once Travis and Appveyor become happy. 😄 |
|
Nice! 😄 |
jslee02
added a commit
that referenced
this pull request
Dec 19, 2015
Fix control file for missing urdfdom-dev dep
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for missing
liburdfdom-devdependency. See #571.Should I add something to the changelog?