Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package reorganizing #587

Merged
merged 31 commits into from
Jan 21, 2016
Merged

Package reorganizing #587

merged 31 commits into from
Jan 21, 2016

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Jan 20, 2016

This pull request reorganizes packages of KIDO into new composition as discussed in #477.

In the new composition, previous dart-core becomes kido, and the additional namespaces in dart are splited into several components: kido-planning, kido-gui, kido-utils, kido-optimizer-nlopt, and kido-optimizer-ipopt.

osgKido is a separate package rather than a component of kido. So osgKido can be used by find_package(osgKido). But, it can be merged into kido as a component easily if @mxgrey wants.

@jslee02 jslee02 added this to the KIDO 0.1.0 milestone Jan 20, 2016
@jslee02 jslee02 changed the title [WIP] Package reorganizing Package reorganizing Jan 20, 2016
@jslee02
Copy link
Member Author

jslee02 commented Jan 20, 2016

Waiting to pass build tests on ppa:dartsim.

@mkoval
Copy link
Collaborator

mkoval commented Jan 20, 2016

It would be nice to add osgKido as a component. This would also be a great opportunity to rename osgKido to dart-gui-osg, to be consistent with the rest of the namespace structure. @mxgrey did you have a strong reason for putting the code where it is?

@mxgrey
Copy link
Member

mxgrey commented Jan 20, 2016

There were a couple reasons for separating osgDart the way we did.

  1. The DART libraries were only split into dart-core and the rest was dart. We didn't want dart to have an OSG dependency, so we separated it out completely.
  2. The naming convention that the OSG maintainers request for extensions to OSG is osgLibraryName.

Since we're totally redoing the package organization, I think it would be a good idea to package osgDart the same way we're packaging all the other dart components. And now that we've established a naming convention for dart extensions, I suppose our own naming conventions should take precedence over the requested convention of the OSG maintainers. And then these changes should obviously carry over to kido.

@mxgrey
Copy link
Member

mxgrey commented Jan 20, 2016

Although if we're not concerned about implementing those changes in DART 6.0, then we could just make the changes in kido and not worry about changing it in dart.

@jslee02
Copy link
Member Author

jslee02 commented Jan 20, 2016

Right, osgDart was named so for those reasons. I agree to rename it to kido-gui-osg following our new convention. Also, it would be good to change the directory name and location of osgKido to kido/gui/osg. How do you think?

As we are releasing DART 6.0 for seamless changing the name, I would like to make the changes in KIDO 1.0 (and 0.1) but not in DART 6.0.

@jslee02 jslee02 mentioned this pull request Jan 20, 2016
Merged
@jslee02
Copy link
Member Author

jslee02 commented Jan 20, 2016

I created #588 for the change of osgKido namespace and directory.

jslee02 and others added 9 commits January 20, 2016 16:16
@jslee02
Update todo comment on cmake build options for extension libraries (#590
f36f21e 
)
@jslee02
Update debian package name for kido-gui-osg
4a7ed50
@jslee02
Use kido::gui::osg namespace for osg gui
adf210f 
- Use leading :: namespace (global namespace) to differ OpenSceneGraph's osg namespace from kido::gui::osg
@jslee02
Update header guards of for new namespace kido::gui::osg
0476bc7
@jslee02
Fix header guards style in gui::osg::render
69ea914
@jslee02
Merge pull request #588 from dartsim/package_reorganizing_osgKido_rename
1bb64a7 
Change namespace and directory of osgKido
@jslee02
Don't include extension headers to kido.hpp; should include the exten…
2088d23 
…sion's headers explicitly when needed
@jslee02
Don't install headers of extension packages twice
d7118fe
@jslee02
Execute assimp symbol tests quietly without messages in cmake time
097f0cf
jslee02 added a commit that referenced this pull request Jan 21, 2016
@jslee02
Merge pull request #587 from dartsim/package_reorganizing
45e649e 
Package reorganizing
@jslee02 jslee02 merged commit 45e649e into kido-0.1.0 Jan 21, 2016
@jslee02 jslee02 deleted the package_reorganizing branch January 27, 2016 06:35
@jslee02 jslee02 mentioned this pull request Mar 29, 2016
Merged
@jslee02 jslee02 mentioned this pull request May 9, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
KIDO 0.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jslee02 @mkoval @mxgrey