Added namespace-scope definitions for constexpr static members #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 2, 2016
Yeah, me neither. In that sense, it would be helpful to add simple note why we need this. Beside on note, 👍 |
|
C++ just really loves throwing those curveballs. 👍 to the changes and 👍 to adding a developer's comment to explain the added declaration/definition (declinition?). |
|
I added the requested comments. |
jslee02
added a commit
that referenced
this pull request
Feb 23, 2016
Added namespace-scope definitions for constexpr static members
jslee02
added a commit
that referenced
this pull request
Aug 5, 2017
jslee02
added a commit
that referenced
this pull request
Aug 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary to ODR-use those member variables. See this StackOverflow post for an explanation.
I honestly think this is quite bizarre - I never knew this was necessary for template classes. However, it did resolve my linking problems. 😄