Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create 'frames' directory if not exists for screenshot #623

Merged
merged 4 commits into from
Mar 3, 2016
Merged

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Mar 2, 2016

This fixes #395 thanks to @olzhas.

@jslee02 jslee02 added this to the DART 6.0.0 milestone Mar 2, 2016
jslee02 added a commit that referenced this pull request Mar 3, 2016
Create 'frames' directory if not exists for screenshot
@jslee02 jslee02 merged commit 840dedf into master Mar 3, 2016
@mxgrey
Copy link
Member

mxgrey commented Mar 3, 2016

I'm a little bit concerned about the ambiguity of the term frames here, since we now have a class called Frames. Same with the name of the variable World::mFrame and function World::getSimFrames(). I've been thinking this for a while, but this pull request reminded me of the matter. I think it would be good to rename these things for the next major release.

@jslee02
Copy link
Member Author

jslee02 commented Mar 3, 2016

Yeah, I recently noticed that too. It seems one of them needs to be renamed (probably SimFrame). How about creating an issue to track this?

@jslee02 jslee02 deleted the screenshot branch March 12, 2016 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GlutWindow::screenshot() doesn't work
2 participants