Removed version check for Bullet. #636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It may have been written during a time when cmake package information wasn't readily available for Bullet on If these changes work for the platforms that we support, then it looks good to me 👍 |
|
Right, FindBullet was not introduced before CMake 2.8. This looks good to me too. 👍 |
jslee02
added a commit
that referenced
this pull request
Mar 20, 2016
Removed version check for Bullet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #625 by removing the test for a Bullet version. This is important because Ubuntu 14.04 ships with Bullet 2.81, which fails the version check for Bullet 2.82 in the current DART
master.I would prefer to remove the check entirely, instead of simply lowering to Bullet 2.81, because we have no evidence to believe that the interface will not work on earlier versions of Bullet. We can re-introduce a version check if we find a compelling reason to do so (e.g. DART fails to build against very old versions).
I also removed the logic that uses
pkg-configonUNIXsystems. Thefind_packagecommand works fine for me on Linux and was unable to find a justification for these gymnastics in thegithistory.. Does anyone know why this check was introduced?