SphereShape #745
Merged
SphereShape #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # dart/collision/fcl/FCLCollisionDetector.cpp
|
It appears that this pull request should be merged after #749. |
# Conflicts: # dart/collision/fcl/FCLCollisionDetector.cpp
|
#749 is merged. |
| @@ -387,8 +386,7 @@ void SupportPolygonVisual::initialize() | |||
| dart::dynamics::Frame::World(), "com"); | |||
|
|
|||
| mComRadius = mCentroidRadius; | |||
| mCom->setShape(std::make_shared<dart::dynamics::EllipsoidShape>( | |||
| mComRadius/2.0*Eigen::Vector3d::Ones())); | |||
There was a problem hiding this comment.
@mxgrey Did you mean mComRadius*2.0 in the first place? In that case, the below code should be just mComRadius rather than mComRadius/4.0.
* Fix typo: grount --> ground * Fix typo: grount --> ground * Update changelog
Fix spelling errors detected by Debian QA checker
jslee02
added
PR: Will merge soon unless anyone has an objection
and removed
PR: Waiting for code review
labels
# Conflicts: # CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as proposed in #724.
This change is