fixed tutorialDominoes-Finished - this did not work #807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I tried the tutorial but it did not work. I could never add a new domino. There were three issues in the code. a) The new domino was never added to the world. b) The collision detection was always detecting a collision because the new domino is in contact with the floor. c) The tutorial description on the website is not related to the code for the collision detection. I fixed a) and b) and added some comments with this commit.
fredowski
added a commit
to fredowski/dartsim.github.io
that referenced
this pull request
Oct 27, 2016
The domino tutorial did not work, because I could not add new dominos. This commit updates the tutorial description according to the pull request dartsim/dart#807
|
This looks good to me. Thanks @fredowski ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried the tutorial with the dominoes but it did not work. I could never add
a new domino. There were three issues in the code.
a) The new domino was never added to the world.
b) The collision detection was always detecting a collision because
the new domino is in contact with the floor.
c) The tutorial description on the website is not related to
the code for the collision detection.
I fixed a) and b) and added some comments with this commit.
This change is