Add createShared() and createUnique() pattern #844
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a set of macros that defines two static functions (
createShared
andcreateUnique
) for creating shared and unique instances of the object. Developers must carefully choose which macro should be used depending on two factors: (1) whether the object requires aligned memory allocation and (2) whether the object's constructor ispublic
orprotected
. Whereas, the users are encouraged to usecreateShared
andcreateUnique
without worrying about those factors if the static creators are defined.Related issue: #813
Open Decisions
create()
vscreateShared()
: We usecreate
andcreateShared
for raw pointer andstd::shared_ptr
, respectivelyThis change is