Add getters for joints/bodies to MetaSkeleton #879
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkoval
approved these changes
Apr 21, 2017
dart/dynamics/MetaSkeleton.hpp
Outdated
| /// Returns the body node of given name. | ||
| /// | ||
| /// When there are multiple body nodes with the same name, returns the first | ||
| /// body node, which is implementation dependent, and prints a warning. |
There was a problem hiding this comment.
Nit: Add a note about how this can occur, i.e. when the MetaSkeleton contains BodyNodes from multiple Skeletons. The same comment applies to the other three functions you added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The newly added APIs are just syntactic sugar to get the joints and body nodes with a name. Probably, some of the implementation are not that efficient.