Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various build issues with Visual Studio 2017 (15.5.3) #956

Merged
merged 7 commits into from
Jan 12, 2018

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Jan 11, 2018

This PR enables back the build tests of DART on Windows with Visual Studio 2017 (15.5.3).

Summary of changes:

Caveat

  • Unit tests are not run by AppVeyor CI yet because custom CMake targets are not shown in Visual Studio (building unit tests are tied to a custom target (i.e., tests)). [This post] says this is fixed in the latest VS preview, but it didn't work for me.
  • ipopt is not installed because it's not supported by vcpkg yet. (Add ipopt  microsoft/vcpkg#233)
  • osg is not installed because gdal, which is one of the osg dependencies, is not built by vcpkg. ([gdal 2.2.2] Fails to build in x86-windows microsoft/vcpkg#2551)

Before creating a pull request

  • Document new methods and classes

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change (N/A)

@jslee02 jslee02 added this to the DART 6.4.0 milestone Jan 11, 2018
@codecov
Copy link

codecov bot commented Jan 12, 2018

Codecov Report

Merging #956 into release-6.4 will increase coverage by <.01%.
The diff coverage is 46.15%.

@@               Coverage Diff               @@
##           release-6.4     #956      +/-   ##
===============================================
+ Coverage        56.87%   56.87%   +<.01%     
===============================================
  Files              310      310              
  Lines            23879    23883       +4     
===============================================
+ Hits             13580    13584       +4     
  Misses           10299    10299
Impacted Files Coverage Δ
dart/common/Resource.hpp 100% <ø> (ø) ⬆️
dart/collision/CollisionDetector.hpp 100% <ø> (ø) ⬆️
dart/math/Geometry.hpp 71.42% <ø> (ø) ⬆️
dart/common/SharedLibrary.cpp 62.06% <ø> (ø) ⬆️
dart/dynamics/ArrowShape.cpp 0% <0%> (ø) ⬆️
dart/math/Geometry.cpp 52.48% <0%> (ø) ⬆️
dart/collision/fcl/FCLCollisionDetector.cpp 83.42% <100%> (ø) ⬆️
dart/collision/CollisionDetector.cpp 92.15% <100%> (+0.66%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant