[WIP] Add ResourceRetriever::getFilePath() #970
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In some cases, it is required to extract the (absolute) file path of a URI (if available). For example,
MeshShape
needs to know the path to a mesh file to infer the path to a texture image, which is given as a relative path. Currently, we don't have a public method to get a file path from a URI unless it's a file URI.PackageResourceRetriever
andDartResourceRetriever
have similar functionality, but it's not public.Proposal
I propose adding
ResourceRetriever::getFilePath()
that returns the absolute file path specified by a URI or an empty string if unavailable.Before creating a pull request
Before merging a pull request
CHANGELOG.md