Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add relative Jacobian functions to MetaSkeleton #997

Merged
merged 10 commits into from
Feb 19, 2018

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Feb 18, 2018

Summary
This PR adds additional Jacobian functions to MetaSkeleton for getting relative Jacobians (and its derivatives) of a frame to an arbitrary frame in the same skeleton.

Caveat
Functions for getting the derivatives of classical relative Jacobian are missing. This will be added in future PRs.

Resolves #230


Before creating a pull request

  • Document new methods and classes

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change

@jslee02 jslee02 added this to the DART 6.4.0 milestone Feb 18, 2018
@codecov
Copy link

codecov bot commented Feb 19, 2018

Codecov Report

Merging #997 into release-6.4 will increase coverage by 0.11%.
The diff coverage is 100%.

@@               Coverage Diff               @@
##           release-6.4     #997      +/-   ##
===============================================
+ Coverage         56.7%   56.81%   +0.11%     
===============================================
  Files              310      310              
  Lines            24050    24104      +54     
===============================================
+ Hits             13637    13695      +58     
+ Misses           10413    10409       -4
Impacted Files Coverage Δ
dart/dynamics/MetaSkeleton.hpp 100% <ø> (ø) ⬆️
dart/dynamics/Skeleton.hpp 83.33% <ø> (ø) ⬆️
dart/dynamics/MetaSkeleton.cpp 45.83% <100%> (+9.55%) ⬆️
dart/dynamics/Skeleton.cpp 66.32% <0%> (+0.11%) ⬆️
dart/dynamics/Frame.cpp 75.09% <0%> (+0.79%) ⬆️

@mxgrey mxgrey self-assigned this Feb 19, 2018
Copy link
Member

@mxgrey mxgrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I really liked the word Jabocian??

@jslee02
Copy link
Member Author

jslee02 commented Feb 19, 2018

You're not the only one. 😂

It seems Travis fails on debug mode because the test size is too large since the test in the 5-level of nested for-statements. Let me address that tomorrow.

@jslee02 jslee02 merged commit ca6596c into release-6.4 Feb 19, 2018
@jslee02 jslee02 deleted the 6.4/relative_jacobian branch February 19, 2018 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants