Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chores: update build-system and darvaza.org dependencies #15

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

amery
Copy link
Contributor

@amery amery commented Oct 2, 2024

Summary by CodeRabbit

Release Notes

  • New Features

    • Introduced gen_mk.sh and get_version.sh scripts to automate Makefile target generation and Go version management.
  • Improvements

    • Updated workflow configurations to streamline build processes and enhance version management.
    • Enhanced Makefile structure for better organization and dependency handling.
    • Increased the maximum line length in code quality rules to 120 characters.
  • Bug Fixes

    • Removed unnecessary files that were no longer required, optimizing project structure.

Signed-off-by: Alejandro Mery <amery@apptly.co>
Copy link

coderabbitai bot commented Oct 2, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request includes significant updates across several files, primarily focusing on the build workflow, Makefile, and Go module dependencies. The workflow configuration in .github/workflows/build.yml has been renamed and adjusted to improve triggering conditions and Go version support. The Makefile has been restructured, introducing new variables and enhancing dependency management. Additionally, the go.mod file reflects updates to the Go version and dependencies. New scripts for generating Makefile targets and retrieving Go version information have been added, while some obsolete scripts have been removed.

Changes

File Change Summary
.github/workflows/build.yml Workflow name changed to "Build"; trigger updated to use branches-ignore for '**-wip'; job name changed to "make"; conditional added for job execution; Go version matrix expanded to 1.21, 1.22, 1.23; action versions updated to v4 and v5.
Makefile .PHONY targets reordered; TOOLSDIR updated to internal/build; new variable OUTDIR added; dynamic version selection for GOLANGCI_LINT and REVIVE introduced; GO_INSTALL_URLS removed; GO_BUILD_CMD updated to output to OUTDIR.
go.mod Go version updated to 1.21; new toolchain version added; dependencies for darvaza.org/core and darvaza.org/x/web updated; several indirect dependencies removed and new ones added.
internal/build/gen_index.sh GROUPS initialized as empty; BASE variable removed; MODULE assigned using mod function; mod function redefined; mod_replace updated to use ROOT_MODULE.
internal/build/gen_mk.sh New script added to automate Makefile target generation based on an input index file, including functions for string manipulation and command generation.
internal/build/get_version.sh New script added to retrieve and process Go version information, including version comparison and validation.
internal/build/revive.toml line-length-limit updated to 120; several rules disabled: max-public-structs, file-header, add-constant, banned-characters.
internal/tools/gen_mk.sh Deleted script that automated Makefile target generation.
internal/tools/tools.go Deleted file indicating it was for tool-related functionality, no longer required.

Poem

In the meadow where we build and play,
The scripts have danced, and changes sway.
With versions new and targets bright,
We hop along, our future in sight!
From tools to builds, we cheer with glee,
For every change sets our projects free! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@amery amery merged commit 610cacb into main Oct 2, 2024
8 of 9 checks passed
@amery amery deleted the pr-amery-chores branch October 2, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant