feat(build): drop Go 1.21 support #82
Conversation
|
Warning Rate limit exceeded@karasz has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 15 minutes and 53 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (11)
WalkthroughThis pull request primarily focuses on upgrading the project's Go version from 1.21 to 1.22. The changes span multiple configuration files, including GitHub Actions workflow, linting configuration, Makefile, go.mod files across different modules, and the Renovate configuration. The upgrade involves updating Go version specifications, adjusting CI/CD matrix, modifying linter settings, and ensuring compatibility with the new Go version. Changes
Possibly related PRs
Suggested labels
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![pullreview-ai[bot]](https://avatars.githubusercontent.com/in/1097279?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
renovate.json (1)
9-9: Consider allowing both Go 1.22 and 1.23The current configuration only allows Go 1.22, but the build matrix in
.github/workflows/build.ymlincludes both 1.22 and 1.23. Consider using"allowedVersions": ">=1.22 <1.24"to match the build matrix.- "allowedVersions": "1.22" + "allowedVersions": ">=1.22 <1.24"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (11)
.github/workflows/build.yml(1 hunks).golangci.yml(1 hunks)Makefile(1 hunks)go.mod(1 hunks)handlers/cblog/go.mod(1 hunks)handlers/discard/go.mod(1 hunks)handlers/filter/go.mod(1 hunks)handlers/logrus/go.mod(1 hunks)handlers/zap/go.mod(1 hunks)handlers/zerolog/go.mod(1 hunks)renovate.json(1 hunks)
✅ Files skipped from review due to trivial changes (7)
- handlers/discard/go.mod
- handlers/logrus/go.mod
- handlers/cblog/go.mod
- handlers/filter/go.mod
- handlers/zap/go.mod
- handlers/zerolog/go.mod
- go.mod
🔇 Additional comments (3)
.github/workflows/build.yml (1)
15-15: LGTM! Matrix configuration aligns with Go version upgradeThe build matrix correctly removes Go 1.21 while maintaining Go 1.22 and 1.23 for forward compatibility.
.golangci.yml (1)
45-45: LGTM! Appropriate linter updates for Go 1.22The replacement of
exportlooprefwithcopyloopvaris correct asexportlooprefis deprecated in Go 1.22. The new linter provides the same functionality with improved compatibility.Makefile (1)
18-19: LGTM! Tool versions are compatible with Go 1.22The updated versions for golangci-lint (v1.63.4) and revive (v1.4) are compatible with Go 1.22.
Signed-off-by: Nagy Károly Gábriel <k@jpi.io>
karasz
force-pushed
the
pr-karasz-go122
branch
from
cb27236 to
ecf8fe7
Compare
Summary by CodeRabbit
Release Notes
Chores
Build