Skip to content
This repository has been archived by the owner on Mar 20, 2024. It is now read-only.

Check substrate-subxt after upgrading its substrate dependency #185

Closed
hackfisher opened this issue Jun 1, 2021 · 3 comments
Closed

Check substrate-subxt after upgrading its substrate dependency #185

hackfisher opened this issue Jun 1, 2021 · 3 comments
Assignees
@fewensa
Labels
P7 High Priority 1 - 3 Low, 4 - 6 Mid, 7 - 9 High

Comments

@hackfisher
Copy link
Contributor

darwinia-network/subxt@2e763e1
@fewensa fewensa mentioned this issue Jun 1, 2021
Merged
@hackfisher
Copy link
Contributor Author

hackfisher commented Jul 21, 2021 •
edited
Loading

This changes in darwinia-network/subxt@2e763e1

and https://github.com/darwinia-network/substrate-subxt

might need to revert when substrate-subxt and darwinia's substrate dep get upgraded.

@hackfisher hackfisher changed the title Fix SignedBlock in substrate-subxt or upgrade its substrate dep Check substrate-subxt after upgrading its substrate dependency Jul 21, 2021
@hackfisher hackfisher added the P5 Mid Priority 1 - 3 Low, 4 - 6 Mid, 7 - 9 High label Jul 21, 2021
@hackfisher hackfisher mentioned this issue Jul 21, 2021
Closed
@xiaoch05
Copy link
Collaborator

if substrate is upgraded for subxt, we should revert this modification.

@hackfisher hackfisher added P7 High Priority 1 - 3 Low, 4 - 6 Mid, 7 - 9 High and removed P5 Mid Priority 1 - 3 Low, 4 - 6 Mid, 7 - 9 High labels Aug 19, 2021
@fewensa fewensa mentioned this issue Aug 31, 2021
Merged
@fewensa
Copy link
Contributor

fewensa commented Nov 19, 2021 •
edited
Loading

The version substrate@darwinia-v0.11.6 is same with this modification

https://github.com/darwinia-network/substrate/blob/74101dc21cfffb4c2d014fcc28edc166d5ca1b16/primitives/runtime/src/lib.rs#L105-L109

darwinia-network/subxt@2e763e1

So there remove by subxt@darwinia-v0.11.6

darwinia-network/subxt@d63ee2c#diff-5cdcc3261dd77eadb37bcd60c5f85affcc9306454ae7bb8128e6d096ae51a631L89

@fewensa fewensa closed this as completed Nov 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@fewensa fewensa

Labels
P7 High Priority 1 - 3 Low, 4 - 6 Mid, 7 - 9 High
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hackfisher @xiaoch05 @fewensa