Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade subxt #6

Merged
merged 11 commits into from
Sep 3, 2021
Merged

Upgrade subxt #6

merged 11 commits into from
Sep 3, 2021

Conversation

fewensa
Copy link

@fewensa fewensa commented Aug 31, 2021

Update subxt and adapt darwinia

liuchengxu and others added 10 commits June 6, 2021 17:10
@liuchengxu
Reorg the order of deps (paritytech#284)
490836f 
* Reorg the order of deps

This patch is simply for easier editor operation when replacing the
substrate deps.

* .
@niklasad1
deps: update jsonrpsee 0.2.0 (paritytech#285)
08a3e65 
* deps: update jsonrpsee 0.2.0

The motivation is to avoid pinning certain alpha versions and to avoid
breaking users builds without having to some `Cargo.lock` updating.

* cargo fmt

* fix tests

* fix a few clippy lints

* cargo fmt
@wuminzhe
Update substrate
13e0761
@wuminzhe
update version
fa1c05d
@wuminzhe
update version
b7014b8
@wuminzhe
update version
f744898
@gregdhill
deps: update jsonrpsee 0.3.0 (paritytech#289)
2749bd3 
Signed-off-by: Gregory Hill <gregorydhill@outlook.com>
@liuchengxu
Add NextKeys and QueuedKeys for session module (paritytech#291)
414f817 
* Add NextKeys and QueuedKeys for session module

* Fix fmt
@fewensa
Merge remote-tracking branch 'parity/master' into metadata-upgrade
1c7769b 
# Conflicts:
#	Cargo.toml
#	client/Cargo.toml
@fewensa
for darwinia
7fd3449
@fewensa fewensa requested review from hackfisher and xiaoch05 August 31, 2021 02:59
@fewensa
Copy link
Author

fewensa commented Aug 31, 2021

keep checking: darwinia-network/bridger#185
this branch use substrate@darwinia-v0.11.3

@hackfisher
Copy link

@fewensa this version is using jsonrpsee 3.0.0?

@fewensa
Copy link
Author

fewensa commented Aug 31, 2021 •
edited
Loading

It's 0.3.0 not 3.0.0
Since this commit paritytech@2749bd3 (paritytech#289), substrate-subxt use jsonrpsee 0.3.0

@fewensa
Copy link
Author

fewensa commented Aug 31, 2021 •
edited
Loading

cargo test will fail.
two reasons:

  1. paritytech/substrate-subxt still fail https://github.com/paritytech/substrate-subxt/runs/3399810085
  2. the test chain is only support RuntimeMetadata::V12, but darwinia is RuntimeMetadata::V13
    https://github.com/darwinia-network/substrate-subxt/blob/2846c0d695c8dd806262057aa3cb8a027fd308b3/.github/workflows/rust.yml#L28

we need test use bridger

@hackfisher
Copy link

@fewensa looks like we've merge the changes in current dependency(metadata branch) to this PR?

We'll merge this and then use master as dependency, right?

@fewensa
Copy link
Author

fewensa commented Aug 31, 2021

yes, when merged the bridge darwinia-ethereum will change to master branch.
we will decide on a better solution later, because there are other chains supported, use tag or multiple branch

@fewensa fewensa mentioned this pull request Aug 31, 2021
Merged
@fewensa fewensa merged commit 931aa5a into master Sep 3, 2021
@fewensa fewensa deleted the metadata-upgrade branch September 3, 2021 01:48
@fewensa
Copy link
Author

fewensa commented Sep 3, 2021 •
edited
Loading

for issue darwinia-network/bridger#256

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hackfisher hackfisher hackfisher approved these changes

@xiaoch05 xiaoch05 Awaiting requested review from xiaoch05

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@fewensa @hackfisher @liuchengxu @niklasad1 @wuminzhe @gregdhill