deps: update jsonrpsee 0.2.0 #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasad1
commented
Jun 8, 2021
| where | ||
| T: DeserializeOwned, | ||
| { | ||
| match sub.next().await { |
There was a problem hiding this comment.
Note: this is a breaking change in jsonrpsee before all failures were ignored and this would only return on valid responses on the subscription stream.
We could change this API in subxt to send back the error here but I didn't want to make any breaking changes.
This error should only occur if the server doesn't send back a response on the stream that is the type T on the subscription.
ascjones
reviewed
Jun 8, 2021
liuchengxu
pushed a commit
to canyon-network/substrate-subxt
that referenced
this pull request
Jun 21, 2021
* deps: update jsonrpsee 0.2.0 The motivation is to avoid pinning certain alpha versions and to avoid breaking users builds without having to some `Cargo.lock` updating. * cargo fmt * fix tests * fix a few clippy lints * cargo fmt
fewensa
added a commit
to darwinia-network/subxt
that referenced
this pull request
Sep 3, 2021
* Reorg the order of deps (paritytech#284) * Reorg the order of deps This patch is simply for easier editor operation when replacing the substrate deps. * . * deps: update jsonrpsee 0.2.0 (paritytech#285) * deps: update jsonrpsee 0.2.0 The motivation is to avoid pinning certain alpha versions and to avoid breaking users builds without having to some `Cargo.lock` updating. * cargo fmt * fix tests * fix a few clippy lints * cargo fmt * Update substrate * update version * update version * update version * deps: update jsonrpsee 0.3.0 (paritytech#289) Signed-off-by: Gregory Hill <gregorydhill@outlook.com> * Add NextKeys and QueuedKeys for session module (paritytech#291) * Add NextKeys and QueuedKeys for session module * Fix fmt * for darwinia * fix test, use `RuntimeMetadata::V13` Co-authored-by: Liu-Cheng Xu <xuliuchengxlc@gmail.com> Co-authored-by: Niklas Adolfsson <niklasadolfsson1@gmail.com> Co-authored-by: Aki Wu <wuminzhe@gmail.com> Co-authored-by: Greg Hill <gregorydhill@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation is to avoid pinning certain alpha versions and to avoid
breaking users builds without having to some
Cargo.lockupdating.I had to add the
tokio1 compatflag toasync-stdin order to because we don't useasync-stdanymore injsonrpsee