Skip to content
This repository has been archived by the owner on Mar 30, 2023. It is now read-only.

Use Parity pallet-balances #8

Closed
Tracked by #9
aurexav opened this issue Sep 21, 2021 · 8 comments
Closed
Tracked by #9

Use Parity pallet-balances #8

aurexav opened this issue Sep 21, 2021 · 8 comments
Assignees

Comments

@aurexav
Copy link
Member

aurexav commented Sep 21, 2021

Why we use custom balances: darwinia-network/darwinia#65

We spend too much extra time on this. But the only advantage is that no need to withdraw after unbond.
And we have to maintain all the pallets which used LockableCurrency. Also, all the mocks need to be changed to use Account.

Furthermore, we can still add an ExtraLock to tracking the unbonding timestamp in darwinia-staking, which could also meet the current requirements.

@boundless-forest
Copy link
Member

I am extremely excited about this code optimization and if it can be implemented.

@hackfisher
Copy link
Contributor

There are some account which have staking can not show their balances on https://polkadot.js.org/apps/?rpc=wss%3A%2F%2Frpc.darwinia.network#/accounts

Might be able to be fixed together with this issue. cc @1022ranji @sxlwar

@aurexav

This comment has been minimized.

@aurexav
Copy link
Member Author

aurexav commented Sep 26, 2021

There are some account which have staking can not show their balances on https://polkadot.js.org/apps/?rpc=wss%3A%2F%2Frpc.darwinia.network#/accounts

Might be able to be fixed together with this issue. cc @1022ranji @sxlwar

darwinia-network/darwinia-common#840 cc @sxlwar

@aurexav
Copy link
Member Author

aurexav commented Oct 26, 2021

Note:

  • Wormhole is using the custom RPC balances_usableBalance

@hackfisher
Copy link
Contributor

hackfisher commented Jan 18, 2022

I added this to kanban and maybe good to have it before darwinia-network/darwinia-common#1055 .

@aurexav
Copy link
Member Author

aurexav commented May 16, 2022

Blocked by

@aurexav aurexav transferred this issue from darwinia-network/darwinia-common Oct 13, 2022
@aurexav aurexav mentioned this issue Oct 13, 2022
38 tasks
@aurexav
Copy link
Member Author

aurexav commented Nov 22, 2022

#12.

@aurexav aurexav closed this as completed Nov 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Status: In Progress
Development

No branches or pull requests

3 participants