Skip to content
This repository has been archived by the owner on Mar 13, 2023. It is now read-only.

Darwinia balance precise migration checklist(In case we will do it) #1055

Closed
8 tasks
hackfisher opened this issue Jan 18, 2022 · 4 comments
Closed
8 tasks
Labels
P-High [Priority] High U-Wontfix [Uncategorized] This will not be worked on

Comments

@hackfisher
Copy link
Contributor

  • Check read and mute entry points
  • Ethereum bridge precision conversion

I would suggest modify the event in substrate side to avoid fork of smart contract in Ethereum side. (Anyway it will be deprecated soon, and could be batch processed in one time)

https://github.com/darwinia-network/darwinia-bridge-sol/blob/b2f8940fbb1caba6ce9b38fa90d8083dfc05b060/contracts/deprecated/issuing-backing/contracts/ethereum/TokenIssuing.sol#L115

  • Substrate to substrate bridge and maybe xRING contract decimal?
  • subql and wormhole-backend?
  • wormhole ui?
  • Smart app
  • Apps and Polkadot.js
  • CEX?
@hackfisher
Copy link
Contributor Author

  • Staking Ledger and the other pallets which stores Balance related data.

@hackfisher hackfisher transferred this issue from darwinia-network/research Jan 18, 2022
@hackfisher
Copy link
Contributor Author

hackfisher commented Jan 18, 2022

                                        ┌────────────────────────┐
                                        │                        │
          ┌─────────────────────────────┤   CEX                  │
          │                             │                        │
          │                             │                        │
          │                             └────────────────────────┘
┌─────────▼──────────┐
│                    │
│Darwinia Precision  │
│                    │
│ 9 -> 18            │
└──────────▲─────────┘                  ┌─────────────────────────┐           ┌───────────────────────┐
           │                            │                         │           │                       │
           │                            │ Darwinia Support        │           │  BSC Message Pallet   │
           └────────────────────────────┤                         ◄───────────┤                       │
                                        │     DVM                 │           │      & Wormhole       │
                                        └─────────────────────────┘           └───────────────────────┘

I'm not convinced before we finally test the solution in Pangoro, but if we want it, we should give it a try, the order and priority should before DVM, and maybe after the Balance pallet replacement. darwinia-network/darwinia-2.0#8

@hackfisher hackfisher added the P-High [Priority] High label Jan 18, 2022
@hackfisher
Copy link
Contributor Author

hackfisher commented Jan 18, 2022

https://docs.binance.org/smart-chain/developer/cross-chain-transfer.html

Like BC and BSC also have different precisions, this is also acceptable.

@hackfisher
Copy link
Contributor Author

hackfisher commented Jan 18, 2022

After considering the complexity and scope of engineering and infrastructure integration, and the engineering arrangement of tasks with higher priories, from a pragmatic point of view, I decide not to make the change finally.

The concept elaboration borrow from BC and BSC is enough for education and docs. Only Dispatch precompile which is calling from Darwinia Smart Chain to native chain(Darwinia Chain) requires attention of precision conversion.

And changing only Darwinia will cause different practice between Crab and Darwinia, which is not good for Crab in this part as canary role.

@hackfisher hackfisher added the U-Wontfix [Uncategorized] This will not be worked on label Jan 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P-High [Priority] High U-Wontfix [Uncategorized] This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants