Make fee market instantiable #1171
Conversation
|
@hackfisher @AurevoirXavier Please take a review! This is a top priority! |
| 0 => FeeMarket::market_fee().and_then(|fee| Some(darwinia_fee_market_rpc_runtime_api::Fee { amount: fee })), | ||
| 1 => WithParachainFeeMarket::market_fee().and_then(|fee| Some(darwinia_fee_market_rpc_runtime_api::Fee { amount: fee })), |
There was a problem hiding this comment.
Acceptable but maybe better to match against the pallet's index instead of Instance index?
Instance index is part the implementation instead of interface, and should not be exposed?
FeeMarket is Instance1 (0 =>...), WithParachainFeeMarket is Instance2 (1 =>...), as a result the instance concept is also changed here, working as another concept for rpc interface.
There was a problem hiding this comment.
Same issue also applies to usable_balance rpc interface, especially do internal implementation refactor changing from "Instance0 and Instannce1" to "Instance1 and Instannce2".
But since apps has already been use it, we just keep it as it is for now considering compatibility.
Commit ecc88c3Pangolin
+ Pallet: "WithParachainFeeMarket"Pangoro
|
As I didn't change the
locked_idorpallet_idof the original pangolin<> pangoro fee market config, so no migration needs.Note: The original fee market runtime API has broken changes, add an extra
instance: u8param.