-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release council election locks #1341
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Check 9eb32ea
|
Check 9eb32ea
|
Check 9eb32ea
|
Check 9eb32ea
|
let _ = migration::clear_storage_prefix(b"PhragmenElection", b"Voting", &[], None, None); | ||
let _ = migration::clear_storage_prefix(b"TechnicalMembership", b"Members", &[], None, None); | ||
let _ = migration::clear_storage_prefix(b"TechnicalMembership", b"Prime", &[], None, None); | ||
[ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you provides more information about the underlying logic behind this migration? I am not familar with the PhragmenElection module, and I have the following questions:
- Why reserve then remove_lock, are both of them necessary?
Voter { votes: "[0x203e49868a6ce5c9cebc8ee260ec9840335d7d27]", stake: 99793500000000000000, deposit: 100009600000000000000 }
We don't need to care about the stake field?
I don't have enough knowledge to review this now, undless takes some time to figure out what it does in the PhragmenElection and staking electtion. Or I believe in your solution and click the Approve green button(I don't want to do that).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You've just answered your question.
Remove lock for stake. Unreserve for deposit.
Closes #1339.