Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use deposit_creating #1453

Merged
merged 2 commits into from
Mar 25, 2024
Merged

Use deposit_creating #1453

merged 2 commits into from
Mar 25, 2024

Conversation

aurexav
Copy link
Member

@aurexav aurexav commented Mar 22, 2024

Because of the code at https://github.com/paritytech/polkadot-sdk/blob/master/substrate/frame/system/src/lib.rs#L2194, allocation will fail for accounts with a zero balance.

Closes #1452.

Verified

This commit was signed with the committer’s verified signature.
joshcooper Josh Cooper
Fix
Copy link

Check 689f070 crab-dev

Check runtime version

Check runtime storage

Copy link

Check 689f070 darwinia-dev

Check runtime version

Check runtime storage

Copy link

Check 689f070 pangolin-dev

Check runtime version

Check runtime storage

@aurexav aurexav merged commit bdac83d into main Mar 25, 2024
10 checks passed
@aurexav aurexav deleted the xavier/f branch March 25, 2024 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Balances::deposit_into_existing required target account to be exist, not suite for reward
2 participants