Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To polkadot-v1.7.2 #1516

Merged
merged 62 commits into from
Jun 28, 2024
Merged

To polkadot-v1.7.2 #1516

merged 62 commits into from
Jun 28, 2024

Conversation

AurevoirXavier
Copy link
Member

No description provided.

@AurevoirXavier AurevoirXavier added the C-Benchmark [Component] Something abouh benchmark label Jun 27, 2024
@AurevoirXavier AurevoirXavier added the U-CI/CD [Uncategorized] Something about CI/CD label Jun 27, 2024
@AurevoirXavier AurevoirXavier marked this pull request as ready for review June 27, 2024 02:47

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

precompile/deposit/src/lib.rs Show resolved Hide resolved
runtime/common/src/benchmark_helper.rs Show resolved Hide resolved
runtime/common/src/lib.rs Show resolved Hide resolved
runtime/common/src/pallet_config.rs Outdated Show resolved Hide resolved
Copy link

Check 3a52562 crab-dev

Check runtime version

Check runtime storage

Copy link

Check 3a52562 darwinia-dev

Check runtime version

Check runtime storage

Copy link

Check 3a52562 koi-dev

Check runtime version

Check runtime storage

- Pallet: "Identity"
+ Pallet: "MessageQueue"

Pallet AssetManager
- Entry: StorageEntryMetadata { name: "LocalAssetCounter", modifier: Default, ty: Plain(UntrackedSymbol { id: 6, marker: PhantomData<fn() -> core::any::TypeId> }), default: [0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0], docs: [" Stores the counter of the number of local assets that have been", " created so far", " This value can be used to salt the creation of an assetId, e.g.,", " by hashing it. This is particularly useful for cases like moonbeam", " where letting users choose their assetId would result in collision", " in the evm side."] }
- Entry: StorageEntryMetadata { name: "LocalAssetDeposit", modifier: Optional, ty: Map { hashers: [Blake2_128Concat], key: UntrackedSymbol { id: 11, marker: PhantomData<fn() -> core::any::TypeId> }, value: UntrackedSymbol { id: 515, marker: PhantomData<fn() -> core::any::TypeId> } }, default: [0], docs: [" Local asset deposits, a mapping from assetId to a struct", " holding the creator (from which the deposit was reserved) and", " the deposit amount"] }

Pallet Balances
+ Entry: StorageEntryMetadata { name: "Holds", modifier: Default, ty: Map { hashers: [Blake2_128Concat], key: UntrackedSymbol { id: 0, marker: PhantomData<fn() -> core::any::TypeId> }, value: UntrackedSymbol { id: 354, marker: PhantomData<fn() -> core::any::TypeId> } }, default: [0], docs: [" Holds on account balances."] }
- Entry: StorageEntryMetadata { name: "Holds", modifier: Default, ty: Map { hashers: [Blake2_128Concat], key: UntrackedSymbol { id: 0, marker: PhantomData<fn() -> core::any::TypeId> }, value: UntrackedSymbol { id: 353, marker: PhantomData<fn() -> core::any::TypeId> } }, default: [0], docs: [" Holds on account balances."] }

Pallet DmpQueue
- Entry: StorageEntryMetadata { name: "Configuration", modifier: Default, ty: Plain(UntrackedSymbol { id: 510, marker: PhantomData<fn() -> core::any::TypeId> }), default: [7, 0, 228, 11, 84, 2, 2, 0, 4, 0], docs: [" The configuration."] }
- Entry: StorageEntryMetadata { name: "CounterForOverweight", modifier: Default, ty: Plain(UntrackedSymbol { id: 4, marker: PhantomData<fn() -> core::any::TypeId> }), default: [0, 0, 0, 0], docs: ["Counter for the related counted storage map"] }
+ Entry: StorageEntryMetadata { name: "MigrationStatus", modifier: Default, ty: Plain(UntrackedSymbol { id: 504, marker: PhantomData<fn() -> core::any::TypeId> }), default: [0], docs: [" The migration state of this pallet."] }
- Entry: StorageEntryMetadata { name: "Overweight", modifier: Optional, ty: Map { hashers: [Blake2_128Concat], key: UntrackedSymbol { id: 11, marker: PhantomData<fn() -> core::any::TypeId> }, value: UntrackedSymbol { id: 513, marker: PhantomData<fn() -> core::any::TypeId> } }, default: [0], docs: [" The overweight messages."] }
- Entry: StorageEntryMetadata { name: "PageIndex", modifier: Default, ty: Plain(UntrackedSymbol { id: 511, marker: PhantomData<fn() -> core::any::TypeId> }), default: [0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0], docs: [" The page index."] }
- Entry: StorageEntryMetadata { name: "Pages", modifier: Default, ty: Map { hashers: [Blake2_128Concat], key: UntrackedSymbol { id: 4, marker: PhantomData<fn() -> core::any::TypeId> }, value: UntrackedSymbol { id: 512, marker: PhantomData<fn() -> core::any::TypeId> } }, default: [0], docs: [" The queue pages."] }

Pallet ParachainSystem
+ Entry: StorageEntryMetadata { name: "AggregatedUnincludedSegment", modifier: Optional, ty: Plain(UntrackedSymbol { id: 329, marker: PhantomData<fn() -> core::any::TypeId> }), default: [0], docs: [" Storage field that keeps track of bandwidth used by the unincluded segment along with the", " latest HRMP watermark. Used for limiting the acceptance of new blocks with", " respect to relay chain constraints."] }
- Entry: StorageEntryMetadata { name: "AggregatedUnincludedSegment", modifier: Optional, ty: Plain(UntrackedSymbol { id: 328, marker: PhantomData<fn() -> core::any::TypeId> }), default: [0], docs: [" Storage field that keeps track of bandwidth used by the unincluded segment along with the", " latest the latest HRMP watermark. Used for limiting the acceptance of new blocks with", " respect to relay chain constraints."] }
- Entry: StorageEntryMetadata { name: "AuthorizedUpgrade", modifier: Optional, ty: Plain(UntrackedSymbol { id: 344, marker: PhantomData<fn() -> core::any::TypeId> }), default: [0], docs: [" The next authorized upgrade, if there is one."] }
+ Entry: StorageEntryMetadata { name: "HostConfiguration", modifier: Optional, ty: Plain(UntrackedSymbol { id: 337, marker: PhantomData<fn() -> core::any::TypeId> }), default: [0], docs: [" The parachain host configuration that was obtained from the relay parent.", "", " This field is meant to be updated each block with the validation data inherent. Therefore,", " before processing of the inherent, e.g. in `on_initialize` this data may be stale.", "", " This data is also absent from the genesis."] }
- Entry: StorageEntryMetadata { name: "HostConfiguration", modifier: Optional, ty: Plain(UntrackedSymbol { id: 336, marker: PhantomData<fn() -> core::any::TypeId> }), default: [0], docs: [" The parachain host configuration that was obtained from the relay parent.", "", " This field is meant to be updated each block with the validation data inherent. Therefore,", " before processing of the inherent, e.g. in `on_initialize` this data may be stale.", "", " This data is also absent from the genesis."] }
+ Entry: StorageEntryMetadata { name: "LastRelayChainBlockNumber", modifier: Default, ty: Plain(UntrackedSymbol { id: 4, marker: PhantomData<fn() -> core::any::TypeId> }), default: [0, 0, 0, 0], docs: [" The relay chain block number associated with the last parachain block.", "", " This is updated in `on_finalize`."] }
- Entry: StorageEntryMetadata { name: "LastRelayChainBlockNumber", modifier: Default, ty: Plain(UntrackedSymbol { id: 4, marker: PhantomData<fn() -> core::any::TypeId> }), default: [0, 0, 0, 0], docs: [" The relay chain block number associated with the last parachain block."] }
+ Entry: StorageEntryMetadata { name: "RelevantMessagingState", modifier: Optional, ty: Plain(UntrackedSymbol { id: 332, marker: PhantomData<fn() -> core::any::TypeId> }), default: [0], docs: [" The snapshot of some state related to messaging relevant to the current parachain as per", " the relay parent.", "", " This field is meant to be updated each block with the validation data inherent. Therefore,", " before processing of the inherent, e.g. in `on_initialize` this data may be stale.", "", " This data is also absent from the genesis."] }
- Entry: StorageEntryMetadata { name: "RelevantMessagingState", modifier: Optional, ty: Plain(UntrackedSymbol { id: 331, marker: PhantomData<fn() -> core::any::TypeId> }), default: [0], docs: [" The snapshot of some state related to messaging relevant to the current parachain as per", " the relay parent.", "", " This field is meant to be updated each block with the validation data inherent. Therefore,", " before processing of the inherent, e.g. in `on_initialize` this data may be stale.", "", " This data is also absent from the genesis."] }
+ Entry: StorageEntryMetadata { name: "UnincludedSegment", modifier: Default, ty: Plain(UntrackedSymbol { id: 320, marker: PhantomData<fn() -> core::any::TypeId> }), default: [0], docs: [" Latest included block descendants the runtime accepted. In other words, these are", " ancestors of the currently executing block which have not been included in the observed", " relay-chain state.", "", " The segment length is limited by the capacity returned from the [`ConsensusHook`] configured", " in the pallet."] }
- Entry: StorageEntryMetadata { name: "UnincludedSegment", modifier: Default, ty: Plain(UntrackedSymbol { id: 319, marker: PhantomData<fn() -> core::any::TypeId> }), default: [0], docs: [" Latest included block descendants the runtime accepted. In other words, these are", " ancestors of the currently executing block which have not been included in the observed", " relay-chain state.", "", " The segment length is limited by the capacity returned from the [`ConsensusHook`] configured", " in the pallet."] }
+ Entry: StorageEntryMetadata { name: "UpgradeGoAhead", modifier: Default, ty: Plain(UntrackedSymbol { id: 327, marker: PhantomData<fn() -> core::any::TypeId> }), default: [0], docs: [" Optional upgrade go-ahead signal from the relay-chain.", "", " This storage item is a mirror of the corresponding value for the current parachain from the", " relay-chain. This value is ephemeral which means it doesn't hit the storage. This value is", " set after the inherent."] }
- Entry: StorageEntryMetadata { name: "UpgradeGoAhead", modifier: Default, ty: Plain(UntrackedSymbol { id: 326, marker: PhantomData<fn() -> core::any::TypeId> }), default: [0], docs: [" Optional upgrade go-ahead signal from the relay-chain.", "", " This storage item is a mirror of the corresponding value for the current parachain from the", " relay-chain. This value is ephemeral which means it doesn't hit the storage. This value is", " set after the inherent."] }
+ Entry: StorageEntryMetadata { name: "UpgradeRestrictionSignal", modifier: Default, ty: Plain(UntrackedSymbol { id: 330, marker: PhantomData<fn() -> core::any::TypeId> }), default: [0], docs: [" An option which indicates if the relay-chain restricts signalling a validation code upgrade.", " In other words, if this is `Some` and [`NewValidationCode`] is `Some` then the produced", " candidate will be invalid.", "", " This storage item is a mirror of the corresponding value for the current parachain from the", " relay-chain. This value is ephemeral which means it doesn't hit the storage. This value is", " set after the inherent."] }
- Entry: StorageEntryMetadata { name: "UpgradeRestrictionSignal", modifier: Default, ty: Plain(UntrackedSymbol { id: 329, marker: PhantomData<fn() -> core::any::TypeId> }), default: [0], docs: [" An option which indicates if the relay-chain restricts signalling a validation code upgrade.", " In other words, if this is `Some` and [`NewValidationCode`] is `Some` then the produced", " candidate will be invalid.", "", " This storage item is a mirror of the corresponding value for the current parachain from the", " relay-chain. This value is ephemeral which means it doesn't hit the storage. This value is", " set after the inherent."] }
+ Entry: StorageEntryMetadata { name: "UpwardDeliveryFeeFactor", modifier: Default, ty: Plain(UntrackedSymbol { id: 345, marker: PhantomData<fn() -> core::any::TypeId> }), default: [0, 0, 100, 167, 179, 182, 224, 13, 0, 0, 0, 0, 0, 0, 0, 0], docs: [" The factor to multiply the base delivery fee by for UMP."] }
+ Entry: StorageEntryMetadata { name: "ValidationData", modifier: Optional, ty: Plain(UntrackedSymbol { id: 59, marker: PhantomData<fn() -> core::any::TypeId> }), default: [0], docs: [" The [`PersistedValidationData`] set for this block.", " This value is expected to be set only once per block and it's never stored", " in the trie."] }
- Entry: StorageEntryMetadata { name: "ValidationData", modifier: Optional, ty: Plain(UntrackedSymbol { id: 59, marker: PhantomData<fn() -> core::any::TypeId> }), default: [0], docs: [" The [`PersistedValidationData`] set for this block.", " This value is expected to be set only once per block and it's never stored", " in the trie."] }

Pallet PolkadotXcm
+ Entry: StorageEntryMetadata { name: "AssetTraps", modifier: Default, ty: Map { hashers: [Identity], key: UntrackedSymbol { id: 12, marker: PhantomData<fn() -> core::any::TypeId> }, value: UntrackedSymbol { id: 4, marker: PhantomData<fn() -> core::any::TypeId> } }, default: [0, 0, 0, 0], docs: [" The existing asset traps.", "", " Key is the blake2 256 hash of (origin, versioned `Assets`) pair. Value is the number of", " times this pair has been trapped (usually just 1 if it exists at all)."] }
- Entry: StorageEntryMetadata { name: "AssetTraps", modifier: Default, ty: Map { hashers: [Identity], key: UntrackedSymbol { id: 12, marker: PhantomData<fn() -> core::any::TypeId> }, value: UntrackedSymbol { id: 4, marker: PhantomData<fn() -> core::any::TypeId> } }, default: [0, 0, 0, 0], docs: [" The existing asset traps.", "", " Key is the blake2 256 hash of (origin, versioned `MultiAssets`) pair. Value is the number of", " times this pair has been trapped (usually just 1 if it exists at all)."] }
+ Entry: StorageEntryMetadata { name: "LockedFungibles", modifier: Optional, ty: Map { hashers: [Blake2_128Concat], key: UntrackedSymbol { id: 0, marker: PhantomData<fn() -> core::any::TypeId> }, value: UntrackedSymbol { id: 499, marker: PhantomData<fn() -> core::any::TypeId> } }, default: [0], docs: [" Fungible assets which we know are locked on this chain."] }
- Entry: StorageEntryMetadata { name: "LockedFungibles", modifier: Optional, ty: Map { hashers: [Blake2_128Concat], key: UntrackedSymbol { id: 0, marker: PhantomData<fn() -> core::any::TypeId> }, value: UntrackedSymbol { id: 504, marker: PhantomData<fn() -> core::any::TypeId> } }, default: [0], docs: [" Fungible assets which we know are locked on this chain."] }
+ Entry: StorageEntryMetadata { name: "RemoteLockedFungibles", modifier: Optional, ty: Map { hashers: [Twox64Concat, Blake2_128Concat, Blake2_128Concat], key: UntrackedSymbol { id: 493, marker: PhantomData<fn() -> core::any::TypeId> }, value: UntrackedSymbol { id: 495, marker: PhantomData<fn() -> core::any::TypeId> } }, default: [0], docs: [" Fungible assets which we know are locked on a remote chain."] }
- Entry: StorageEntryMetadata { name: "RemoteLockedFungibles", modifier: Optional, ty: Map { hashers: [Twox64Concat, Blake2_128Concat, Blake2_128Concat], key: UntrackedSymbol { id: 498, marker: PhantomData<fn() -> core::any::TypeId> }, value: UntrackedSymbol { id: 500, marker: PhantomData<fn() -> core::any::TypeId> } }, default: [0], docs: [" Fungible assets which we know are locked on a remote chain."] }
+ Entry: StorageEntryMetadata { name: "SupportedVersion", modifier: Optional, ty: Map { hashers: [Twox64Concat, Blake2_128Concat], key: UntrackedSymbol { id: 486, marker: PhantomData<fn() -> core::any::TypeId> }, value: UntrackedSymbol { id: 4, marker: PhantomData<fn() -> core::any::TypeId> } }, default: [0], docs: [" The Latest versions that we know various locations support."] }
- Entry: StorageEntryMetadata { name: "SupportedVersion", modifier: Optional, ty: Map { hashers: [Twox64Concat, Blake2_128Concat], key: UntrackedSymbol { id: 491, marker: PhantomData<fn() -> core::any::TypeId> }, value: UntrackedSymbol { id: 4, marker: PhantomData<fn() -> core::any::TypeId> } }, default: [0], docs: [" The Latest versions that we know various locations support."] }
+ Entry: StorageEntryMetadata { name: "VersionDiscoveryQueue", modifier: Default, ty: Plain(UntrackedSymbol { id: 488, marker: PhantomData<fn() -> core::any::TypeId> }), default: [0], docs: [" Destinations whose latest XCM version we would like to know. Duplicates not allowed, and", " the `u32` counter is the number of times that a send to the destination has been attempted,", " which is used as a prioritization."] }
- Entry: StorageEntryMetadata { name: "VersionDiscoveryQueue", modifier: Default, ty: Plain(UntrackedSymbol { id: 493, marker: PhantomData<fn() -> core::any::TypeId> }), default: [0], docs: [" Destinations whose latest XCM version we would like to know. Duplicates not allowed, and", " the `u32` counter is the number of times that a send to the destination has been attempted,", " which is used as a prioritization."] }
+ Entry: StorageEntryMetadata { name: "VersionNotifiers", modifier: Optional, ty: Map { hashers: [Twox64Concat, Blake2_128Concat], key: UntrackedSymbol { id: 486, marker: PhantomData<fn() -> core::any::TypeId> }, value: UntrackedSymbol { id: 11, marker: PhantomData<fn() -> core::any::TypeId> } }, default: [0], docs: [" All locations that we have requested version notifications from."] }
- Entry: StorageEntryMetadata { name: "VersionNotifiers", modifier: Optional, ty: Map { hashers: [Twox64Concat, Blake2_128Concat], key: UntrackedSymbol { id: 491, marker: PhantomData<fn() -> core::any::TypeId> }, value: UntrackedSymbol { id: 11, marker: PhantomData<fn() -> core::any::TypeId> } }, default: [0], docs: [" All locations that we have requested version notifications from."] }
+ Entry: StorageEntryMetadata { name: "VersionNotifyTargets", modifier: Optional, ty: Map { hashers: [Twox64Concat, Blake2_128Concat], key: UntrackedSymbol { id: 486, marker: PhantomData<fn() -> core::any::TypeId> }, value: UntrackedSymbol { id: 487, marker: PhantomData<fn() -> core::any::TypeId> } }, default: [0], docs: [" The target locations that are subscribed to our version changes, as well as the most recent", " of our versions we informed them of."] }
- Entry: StorageEntryMetadata { name: "VersionNotifyTargets", modifier: Optional, ty: Map { hashers: [Twox64Concat, Blake2_128Concat], key: UntrackedSymbol { id: 491, marker: PhantomData<fn() -> core::any::TypeId> }, value: UntrackedSymbol { id: 492, marker: PhantomData<fn() -> core::any::TypeId> } }, default: [0], docs: [" The target locations that are subscribed to our version changes, as well as the most recent", " of our versions we informed them of."] }

Pallet Preimage
+ Entry: StorageEntryMetadata { name: "RequestStatusFor", modifier: Optional, ty: Map { hashers: [Identity], key: UntrackedSymbol { id: 12, marker: PhantomData<fn() -> core::any::TypeId> }, value: UntrackedSymbol { id: 455, marker: PhantomData<fn() -> core::any::TypeId> } }, default: [0], docs: [" The request status of a given hash."] }
+ Entry: StorageEntryMetadata { name: "StatusFor", modifier: Optional, ty: Map { hashers: [Identity], key: UntrackedSymbol { id: 12, marker: PhantomData<fn() -> core::any::TypeId> }, value: UntrackedSymbol { id: 452, marker: PhantomData<fn() -> core::any::TypeId> } }, default: [0], docs: [" The request status of a given hash."] }
- Entry: StorageEntryMetadata { name: "StatusFor", modifier: Optional, ty: Map { hashers: [Identity], key: UntrackedSymbol { id: 12, marker: PhantomData<fn() -> core::any::TypeId> }, value: UntrackedSymbol { id: 456, marker: PhantomData<fn() -> core::any::TypeId> } }, default: [0], docs: [" The request status of a given hash."] }

Pallet Referenda
+ Entry: StorageEntryMetadata { name: "MetadataOf", modifier: Optional, ty: Map { hashers: [Blake2_128Concat], key: UntrackedSymbol { id: 4, marker: PhantomData<fn() -> core::any::TypeId> }, value: UntrackedSymbol { id: 12, marker: PhantomData<fn() -> core::any::TypeId> } }, default: [0], docs: [" The metadata is a general information concerning the referendum.", " The `Hash` refers to the preimage of the `Preimages` provider which can be a JSON", " dump or IPFS hash of a JSON file.", "", " Consider a garbage collection for a metadata of finished referendums to `unrequest` (remove)", " large preimages."] }
- Entry: StorageEntryMetadata { name: "MetadataOf", modifier: Optional, ty: Map { hashers: [Blake2_128Concat], key: UntrackedSymbol { id: 4, marker: PhantomData<fn() -> core::any::TypeId> }, value: UntrackedSymbol { id: 12, marker: PhantomData<fn() -> core::any::TypeId> } }, default: [0], docs: [" The metadata is a general information concerning the referendum.", " The `PreimageHash` refers to the preimage of the `Preimages` provider which can be a JSON", " dump or IPFS hash of a JSON file.", "", " Consider a garbage collection for a metadata of finished referendums to `unrequest` (remove)", " large preimages."] }

Pallet Scheduler
+ Entry: StorageEntryMetadata { name: "Agenda", modifier: Default, ty: Map { hashers: [Twox64Concat], key: UntrackedSymbol { id: 4, marker: PhantomData<fn() -> core::any::TypeId> }, value: UntrackedSymbol { id: 447, marker: PhantomData<fn() -> core::any::TypeId> } }, default: [0], docs: [" Items to be executed, indexed by the block number that they should be executed on."] }
- Entry: StorageEntryMetadata { name: "Agenda", modifier: Default, ty: Map { hashers: [Twox64Concat], key: UntrackedSymbol { id: 4, marker: PhantomData<fn() -> core::any::TypeId> }, value: UntrackedSymbol { id: 451, marker: PhantomData<fn() -> core::any::TypeId> } }, default: [0], docs: [" Items to be executed, indexed by the block number that they should be executed on."] }

Pallet System
+ Entry: StorageEntryMetadata { name: "AuthorizedUpgrade", modifier: Optional, ty: Plain(UntrackedSymbol { id: 308, marker: PhantomData<fn() -> core::any::TypeId> }), default: [0], docs: [" `Some` if a code upgrade has been authorized."] }

Pallet Timestamp
+ Entry: StorageEntryMetadata { name: "DidUpdate", modifier: Default, ty: Plain(UntrackedSymbol { id: 31, marker: PhantomData<fn() -> core::any::TypeId> }), default: [0], docs: [" Whether the timestamp has been updated in this block.", "", " This value is updated to `true` upon successful submission of a timestamp by a node.", " It is then checked at the end of each block execution in the `on_finalize` hook."] }
- Entry: StorageEntryMetadata { name: "DidUpdate", modifier: Default, ty: Plain(UntrackedSymbol { id: 37, marker: PhantomData<fn() -> core::any::TypeId> }), default: [0], docs: [" Did the timestamp get updated in this block?"] }
+ Entry: StorageEntryMetadata { name: "Now", modifier: Default, ty: Plain(UntrackedSymbol { id: 11, marker: PhantomData<fn() -> core::any::TypeId> }), default: [0, 0, 0, 0, 0, 0, 0, 0], docs: [" The current time for the current block."] }
- Entry: StorageEntryMetadata { name: "Now", modifier: Default, ty: Plain(UntrackedSymbol { id: 11, marker: PhantomData<fn() -> core::any::TypeId> }), default: [0, 0, 0, 0, 0, 0, 0, 0], docs: [" Current time for the current block."] }

Pallet Treasury
+ Entry: StorageEntryMetadata { name: "SpendCount", modifier: Default, ty: Plain(UntrackedSymbol { id: 4, marker: PhantomData<fn() -> core::any::TypeId> }), default: [0, 0, 0, 0], docs: [" The count of spends that have been made."] }
+ Entry: StorageEntryMetadata { name: "Spends", modifier: Optional, ty: Map { hashers: [Twox64Concat], key: UntrackedSymbol { id: 4, marker: PhantomData<fn() -> core::any::TypeId> }, value: UntrackedSymbol { id: 407, marker: PhantomData<fn() -> core::any::TypeId> } }, default: [0], docs: [" Spends that have been approved and being processed."] }

Pallet XcmpQueue
- Entry: StorageEntryMetadata { name: "CounterForOverweight", modifier: Default, ty: Plain(UntrackedSymbol { id: 4, marker: PhantomData<fn() -> core::any::TypeId> }), default: [0, 0, 0, 0], docs: ["Counter for the related counted storage map"] }
+ Entry: StorageEntryMetadata { name: "DeliveryFeeFactor", modifier: Default, ty: Map { hashers: [Twox64Concat], key: UntrackedSymbol { id: 66, marker: PhantomData<fn() -> core::any::TypeId> }, value: UntrackedSymbol { id: 345, marker: PhantomData<fn() -> core::any::TypeId> } }, default: [0, 0, 100, 167, 179, 182, 224, 13, 0, 0, 0, 0, 0, 0, 0, 0], docs: [" The factor to multiply the base delivery fee by."] }
- Entry: StorageEntryMetadata { name: "InboundXcmpMessages", modifier: Default, ty: Map { hashers: [Blake2_128Concat, Twox64Concat], key: UntrackedSymbol { id: 478, marker: PhantomData<fn() -> core::any::TypeId> }, value: UntrackedSymbol { id: 14, marker: PhantomData<fn() -> core::any::TypeId> } }, default: [0], docs: [" Inbound aggregate XCMP messages. It can only be one per ParaId/block."] }
- Entry: StorageEntryMetadata { name: "InboundXcmpStatus", modifier: Default, ty: Plain(UntrackedSymbol { id: 472, marker: PhantomData<fn() -> core::any::TypeId> }), default: [0], docs: [" Status of the inbound XCMP channels."] }
+ Entry: StorageEntryMetadata { name: "InboundXcmpSuspended", modifier: Default, ty: Plain(UntrackedSymbol { id: 472, marker: PhantomData<fn() -> core::any::TypeId> }), default: [0], docs: [" The suspended inbound XCMP channels. All others are not suspended.", "", " This is a `StorageValue` instead of a `StorageMap` since we expect multiple reads per block", " to different keys with a one byte payload. The access to `BoundedBTreeSet` will be cached", " within the block and therefore only included once in the proof size.", "", " NOTE: The PoV benchmarking cannot know this and will over-estimate, but the actual proof", " will be smaller."] }
- Entry: StorageEntryMetadata { name: "Overweight", modifier: Optional, ty: Map { hashers: [Twox64Concat], key: UntrackedSymbol { id: 11, marker: PhantomData<fn() -> core::any::TypeId> }, value: UntrackedSymbol { id: 484, marker: PhantomData<fn() -> core::any::TypeId> } }, default: [0], docs: [" The messages that exceeded max individual message weight budget.", "", " These message stay in this storage map until they are manually dispatched via", " `service_overweight`."] }
- Entry: StorageEntryMetadata { name: "OverweightCount", modifier: Default, ty: Plain(UntrackedSymbol { id: 11, marker: PhantomData<fn() -> core::any::TypeId> }), default: [0, 0, 0, 0, 0, 0, 0, 0], docs: [" The number of overweight messages ever recorded in `Overweight`. Also doubles as the next", " available free overweight index."] }
+ Entry: StorageEntryMetadata { name: "QueueConfig", modifier: Default, ty: Plain(UntrackedSymbol { id: 479, marker: PhantomData<fn() -> core::any::TypeId> }), default: [32, 0, 0, 0, 48, 0, 0, 0, 8, 0, 0, 0], docs: [" The configuration which controls the dynamics of the outbound queue."] }
- Entry: StorageEntryMetadata { name: "QueueConfig", modifier: Default, ty: Plain(UntrackedSymbol { id: 483, marker: PhantomData<fn() -> core::any::TypeId> }), default: [2, 0, 0, 0, 5, 0, 0, 0, 1, 0, 0, 0, 130, 26, 6, 0, 0, 8, 0, 7, 0, 200, 23, 168, 4, 2, 0, 4, 0], docs: [" The configuration which controls the dynamics of the outbound queue."] }

// BridgeKusamaParachain: pallet_bridge_parachains::<Instance1> = 40,
// BridgeCrabMessages: pallet_bridge_messages::<Instance1> = 41,
// BridgeCrabDispatch: pallet_bridge_dispatch::<Instance1> = 42,
// CrabFeeMarket: pallet_fee_market::<Instance1> = 43
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not keep these comment and give pallet_message_queue a new index 44?

Better safe than sorry, even if the storage of these modules hava been cleared.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only runtime call cares about the index. These won't affect the storage. I think there isn't security issue. Unless there are some on-going scheduled call. But those pallets were removed long time ago.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hackfisher We have some dissicussion internally, what do you think?

Copy link
Contributor

@hackfisher hackfisher Jun 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both options look good to me. I will probably keep them to ensure we maintain good co-coding conventions, as I will not be able to recall why we skipped these indexes in future. Additionally, This encourage others not skipping without comments as we was doing it, new contributors usually following existing code practices.

However, I do not have reasons to argue against it from a security perspective.

runtime/crab/src/lib.rs Show resolved Hide resolved
Copy link
Member

@boundless-forest boundless-forest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a super huge pull request, it took me the whole afternoon to review the changes. I leave some feedback. Most of the changes look good to me. You removed two pallets, and there are also some tasks left to do or migrations needed, such as the asset description migration for the Koi testnet. I assume there will be another PR to handle the migration.

@AurevoirXavier
Copy link
Member Author

I assume there will be another PR to handle the migration.

Yep.

@AurevoirXavier AurevoirXavier merged commit 61e127a into main Jun 28, 2024
10 checks passed
@AurevoirXavier AurevoirXavier deleted the xavier/v1.7.2 branch June 28, 2024 05:22
@AurevoirXavier AurevoirXavier mentioned this pull request Jun 28, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bk-API [Break] This changes API; next release should be major. Bk-Consensus [Break] This changes consensus; next release should be major. Bk-Storage [Break] This changes Storage; next release should be major. C-Benchmark [Component] Something abouh benchmark C-EVM [Component] Something about EVM C-Pallet [Component] Something about pallet C-Runtime [Component] Something about runtime C-Test [Component] Something about test C-XCM [Component] Something about XCM D-Crate [Dependency] From crates.io D-Frontier [Dependency] From Frontier D-Moonbeam [Dependency] From Moonbeam D-PolkadotSDK [Dependency] From polkadot-sdk S-Need Audit PR contains changes to fund-managing logic that should be properly reviewed and externally audited U-CI/CD [Uncategorized] Something about CI/CD
Projects
Status: Done
3 participants