Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring Balances #307

Merged
merged 15 commits into from
Mar 4, 2020
Merged

Refactoring Balances #307

merged 15 commits into from
Mar 4, 2020

Conversation

aurexav
Copy link
Member

@aurexav aurexav commented Feb 29, 2020

No description provided.

@aurexav aurexav requested a review from hackfisher March 2, 2020 15:24
hackfisher
hackfisher requested changes Mar 2, 2020
View reviewed changes
frame/balances/ring/src/lib.rs Outdated Show resolved Hide resolved
hackfisher
hackfisher requested changes Mar 3, 2020
View reviewed changes
frame/support/src/lib.rs Outdated Show resolved Hide resolved
frame/balances/ring/src/lib.rs Outdated Show resolved Hide resolved
frame/balances/ring/src/lib.rs Outdated Show resolved Hide resolved
frame/support/src/lib.rs Outdated Show resolved Hide resolved
@aurexav aurexav mentioned this pull request Mar 3, 2020
Closed
hackfisher
hackfisher approved these changes Mar 4, 2020
View reviewed changes
frame/balances/ring/src/lib.rs Show resolved Hide resolved
@aurexav aurexav linked an issue Mar 4, 2020 that may be closed by this pull request
Dust Account Detection Strategy? #101
Closed
@aurexav
Copy link
Member Author

aurexav commented Mar 4, 2020

Can not Compile. Require #310 Full Upgrade.

@aurexav aurexav merged commit bee19e3 into darwinia-network:develop Mar 4, 2020
@aurexav aurexav deleted the refactoring-balances branch March 4, 2020 08:53
@aurexav aurexav linked an issue Mar 4, 2020 that may be closed by this pull request
Refactoring Balances #258
Closed
@yanganto yanganto mentioned this pull request Mar 9, 2020
Closed
boundless-forest pushed a commit that referenced this pull request Aug 1, 2023
@lovesh
Allow handling fee deductions done by EVM (#307)
42de772 
* Allow handling fee deductions done by EVM

Projects using `pallet_ethereum` need a way to know about fee deducted
by EVM to take appropriate action on the fee like giving it to the
miner. This adds a type `OnChargeTransaction` to pallet's `Config` trait
similar to `OnChargeTransaction` of `pallet_transaction_payment`

Signed-off-by: lovesh <lovesh.bond@gmail.com>

* Fix formatting

Signed-off-by: lovesh <lovesh.bond@gmail.com>

* Fix trait implementation in test

Signed-off-by: lovesh <lovesh.bond@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hackfisher hackfisher hackfisher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactoring Balances Dust Account Detection Strategy?
2 participants
@aurexav @hackfisher