Skip to content

Use sr-tool for Release #632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Apr 11, 2021
Merged

Use sr-tool for Release #632

merged 23 commits into from
Apr 11, 2021

Conversation

fewensa
Copy link
Contributor

@fewensa fewensa commented Mar 24, 2021

  • Automatic test and create release
  • Compile wasm using srtool
  • A simple guide written in Chinese

ref:
#627

@fewensa fewensa mentioned this pull request Mar 24, 2021
@aurexav
Copy link
Member

aurexav commented Mar 26, 2021

Is this working?

Or only the tag will trigger this.

@fewensa
Copy link
Contributor Author

fewensa commented Mar 26, 2021

Is this working?

Or only the tag will trigger this.

Yes, it's working. I have already tested.
when push code to master branch trigger cargo test
when create a new tag will build darwinia binary push to docker registry and build darwinia/crab wasm binary. all binary mount to github release page.

before this pr merge, I'll do a last test in my repository. and reference this link.

@aurexav
Copy link
Member

aurexav commented Mar 26, 2021

Is this working?
Or only the tag will trigger this.

Yes, it's working. I have already tested.
when push code to master branch trigger cargo test
when create a new tag will build darwinia binary push to docker registry and build darwinia/crab wasm binary. all binary mount to github release page.

before this pr merge, I'll do a last test in my repository. and reference this link.

Yes. I want to see the tag process.

@fewensa
Copy link
Contributor Author

fewensa commented Mar 28, 2021

pass the final test, see this link https://github.com/fewensa/darwinia/releases/tag/v0.9.5-7

@hackfisher
Copy link
Contributor

Polkadot repository swiched to chevor's srtool

paritytech/polkadot@3363dcf

@fewensa fewensa mentioned this pull request Apr 6, 2021
@hackfisher
Copy link
Contributor

At least 2 approving reviews are required before merging these PRs, please proceed for the approve or merge if there are no more changes required.

The same for other pull requests.

@aurexav
Copy link
Member

aurexav commented Apr 7, 2021

At least 2 approving reviews are required before merging these PRs, please proceed for the approve or merge if there are no more changes required.

The same for other pull requests.

Review-ing...

@fewensa
Copy link
Contributor Author

fewensa commented Apr 7, 2021

I'm test currently, let's me do some change.

Copy link
Member

@aurexav aurexav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/fewensa/darwinia/releases/download/v0.9.5-7/darwinia_x86_64-linux-gnu

Is this binary support universal linux or just ubuntu-latest?

Also the file size is too large. Please tar with bz2.

@hackfisher
Copy link
Contributor

Related #608 (comment)

fewensa added 3 commits April 8, 2021 11:22
…l, all rust toolchain use nightly-2021-03-15 to support the new darwinia version #636
# Conflicts:
#	.github/workflows/ci.yml
@fewensa
Copy link
Contributor Author

fewensa commented Apr 8, 2021

All question solved by the new commit. and have some new features,

  1. the release.yml enable multi step to build release
  2. change paritytech/srtool to chevdor/srtool
  3. all toolchain use nightly-2021-03-15

@AurevoirXavier

  1. the new commit build binary is support universal linux
  2. the upload binary use bz2 package
  3. update rust toolchain to nightly-2021-03-15, so support pr Release 0.9.6 #636

@hackfisher
About related url, I think @AurevoirXavier says is right, so now also centos:7

@aurexav aurexav changed the title Change deploy strategy Release with sr-tool Apr 8, 2021
@aurexav aurexav changed the title Release with sr-tool Use sr-tool for Release Apr 8, 2021
@aurexav aurexav added the U-CI/CD [Uncategorized] Something about CI/CD label Apr 8, 2021
@fewensa
Copy link
Contributor Author

fewensa commented Apr 8, 2021

@aurexav
Copy link
Member

aurexav commented Apr 8, 2021

Switch toolchain to nightly-2021-03-01

@fewensa
Copy link
Contributor Author

fewensa commented Apr 8, 2021

nightly-2021-03-01

No, can not change it. the chevdor/srtool don't have this version

https://hub.docker.com/r/chevdor/srtool/tags?page=1&ordering=last_updated&name=nightly-2021-03

It's have nightly-2021-03-15

@aurexav
Copy link
Member

aurexav commented Apr 8, 2021

But the CI failed.

Due to rust-lang/rust#83291

@aurexav
Copy link
Member

aurexav commented Apr 8, 2021

Seriously?

CI takes 3 hours.

@wi1dcard seems something wrong with the slack API in previous CI.

@aurexav
Copy link
Member

aurexav commented Apr 11, 2021

Still failed.

@fewensa
Copy link
Contributor Author

fewensa commented Apr 11, 2021

Still failed.

you can see that,
https://github.com/darwinia-network/darwinia/actions/runs/737408184

the compile is success, failed is build image, the reason is can not get secrets, may in pull request no permission to get this.

@fewensa
Copy link
Contributor Author

fewensa commented Apr 11, 2021

Build success.

ci.yml
https://github.com/darwinia-network/darwinia/actions/runs/737700160
trigger by push to to master or pull request to master

release.yml
https://github.com/darwinia-network/darwinia/actions/runs/737408184
trigger by create new tag (must add v prefix to tag name). and need update CHANGELOG.md follow keep a changelog style

this test failed, because fork repository create pull request can not get secrets, but compile is success.

and currently code have some comment, that code will be use in future, the new srtool version have some change.

@aurexav aurexav merged commit b87363a into darwinia-network:master Apr 11, 2021
@aurexav aurexav linked an issue Apr 12, 2021 that may be closed by this pull request
boundless-forest pushed a commit that referenced this pull request Aug 1, 2023
* Skip balance and gas price checks on non-transactional calls

* Update comment

* Ensure account nonce first

* Clear evm integration test unused warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
U-CI/CD [Uncategorized] Something about CI/CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deterministic build release wasm using srtool
4 participants