-
Notifications
You must be signed in to change notification settings - Fork 49
Use sr-tool
for Release
#632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Is this working? Or only the tag will trigger this. |
Yes, it's working. I have already tested. before this pr merge, I'll do a last test in my repository. and reference this link. |
Yes. I want to see the tag process. |
pass the final test, see this link https://github.com/fewensa/darwinia/releases/tag/v0.9.5-7 |
Polkadot repository swiched to chevor's srtool |
At least 2 approving reviews are required before merging these PRs, please proceed for the approve or merge if there are no more changes required. The same for other pull requests. |
Review-ing... |
I'm test currently, let's me do some change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this binary support universal linux or just ubuntu-latest?
Also the file size is too large. Please tar with bz2.
Related #608 (comment) |
…l, all rust toolchain use nightly-2021-03-15 to support the new darwinia version #636
# Conflicts: # .github/workflows/ci.yml
All question solved by the new commit. and have some new features,
@AurevoirXavier
@hackfisher |
…for darwinia in docker image
complete test, see that https://github.com/fewensa/darwinia/releases/tag/v0.9.5-9 |
Switch toolchain to nightly-2021-03-01 |
No, can not change it. the chevdor/srtool don't have this version https://hub.docker.com/r/chevdor/srtool/tags?page=1&ordering=last_updated&name=nightly-2021-03 It's have nightly-2021-03-15 |
But the CI failed. Due to rust-lang/rust#83291 |
Seriously? CI takes 3 hours. @wi1dcard seems something wrong with the slack API in previous CI. |
Still failed. |
you can see that, the compile is success, failed is build image, the reason is can not get |
Build success. ci.yml release.yml
and currently code have some comment, that code will be use in future, the new srtool version have some change. |
* Skip balance and gas price checks on non-transactional calls * Update comment * Ensure account nonce first * Clear evm integration test unused warnings
ref:
#627