Fix inconsistent latest_block_hash #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add `best_hash` method * Update earliest tag matched value * Fix CI tests * Code clean * Fix review comments * Update comment * Fix compile after solving conflicts * Remove the broken changes * Update trait bound * Simplify trait bound
boundless-forest
force-pushed
the
bear-pick-fix
branch
from
c36f36a
to
58db012
Compare
boundless-forest
force-pushed
the
bear-pick-fix
branch
from
58db012
to
7596836
Compare
|
@boundless-forest There are conflicts at, which prevent ci format pass Diff in /home/runner/work/frontier/frontier/frame/evm/src/tests.rs at line 241: |
I'm working on fixinging it (force push to keep the commit history clean). We should respect the CI in this repo in the future, the CI of the branch that we used is not maintained well. |
|
Suggest using the same rust version as darwinia |
nightly-2024-03-17 -> 1.77.0 (darwinia version), but nightly. stable toolchain fails to compile some piece of code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick polkadot-evm#1424