Merge pull request #101 from dpushkarev/preserve-libxml-errors

Preserve libxml errors after failed parsing

src/Sanitizer.php

@@ -230,6 +230,7 @@ public function sanitize($dirty)
 
  // If we couldn't parse the XML then we go no further. Reset and return false
  if (!$loaded) {
+ $this->xmlIssues = self::getXmlErrors();
  $this->resetAfter();
  return false;
  }
@@ -698,4 +699,21 @@ protected function cleanUnsafeNodes(\DOMNode $currentElement) {
  }
  }
  }
+
+ /**
+ * Retrieve array of errors
+ * @return array
+ */
+ private static function getXmlErrors()
+ {
+ $errors = [];
+ foreach (libxml_get_errors() as $error) {
+ $errors[] = [
+ 'message' => trim($error->message),
+ 'line' => $error->line,
+ ];
+ }
+
+ return $errors;
+ }
 }

tests/SanitizerTest.php

@@ -100,7 +100,20 @@ public function testBadXMLReturnsFalse()
  $sanitizer = new Sanitizer();
  $cleanData = $sanitizer->sanitize($initialData);
 
- self::assertSame(false, $cleanData);
+ self::assertFalse($cleanData);
+ self::assertEquals(
+ [
+ [
+ 'message' => 'Opening and ending tag mismatch: line line 8 and svg',
+ 'line' => 15,
+ ],
+ [
+ 'message' => 'Premature end of data in tag svg line 4',
+ 'line' => 16,
+ ],
+ ],
+ $sanitizer->getXmlIssues()
+ );
  }
 
  /**