Allow the enabling of loading large files #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkotter
reviewed
Feb 14, 2024
| @@ -203,7 +226,7 @@ public function sanitize($dirty) | |||
| $this->resetInternal(); | |||
| $this->setUpBefore(); | |||
|
|
|||
| $loaded = $this->xmlDocument->loadXML($dirty); | |||
| $loaded = $this->xmlDocument->loadXML($dirty, $this->getAllowHugeFiles() ? LIBXML_PARSEHUGE : 0); | |||
There was a problem hiding this comment.
If I'm following correctly, by default we won't allow large files but others that are using this library (like the Safe SVG plugin) can utilize the setAllowHugeFiles method to turn that on?
There was a problem hiding this comment.
@dkotter that's correct, we're keeping the functionality the same by default, but allowing this to be enabled at runtime. This could likely be an admin option within Safe SVG ("Allow large SVG uploads?")
dkotter
approved these changes
Feb 21, 2024
ohader
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides a way to resolve #96